On 6/23/23 6:44 AM, David Howells wrote: > Use sendmsg() with MSG_SPLICE_PAGES rather than sendpage. This allows > multiple pages and multipage folios to be passed through. > > TODO: iscsit_fe_sendpage_sg() should perhaps set up a bio_vec array for the > entire set of pages it's going to transfer plus two for the header and > trailer and page fragments to hold the header and trailer - and then call > sendmsg once for the entire message. > > Signed-off-by: David Howells <dhowe...@redhat.com> > cc: Lee Duncan <ldun...@suse.com> > cc: Chris Leech <cle...@redhat.com> > cc: Mike Christie <michael.chris...@oracle.com> > cc: Maurizio Lombardi <mlomb...@redhat.com> > cc: "James E.J. Bottomley" <j...@linux.ibm.com> > cc: "Martin K. Petersen" <martin.peter...@oracle.com> > cc: "David S. Miller" <da...@davemloft.net> > cc: Eric Dumazet <eduma...@google.com> > cc: Jakub Kicinski <k...@kernel.org> > cc: Paolo Abeni <pab...@redhat.com> > cc: Jens Axboe <ax...@kernel.dk> > cc: Matthew Wilcox <wi...@infradead.org> > cc: Al Viro <v...@zeniv.linux.org.uk> > cc: open-iscsi@googlegroups.com > cc: linux-s...@vger.kernel.org > cc: target-de...@vger.kernel.org > cc: net...@vger.kernel.org > --- > > Notes: > ver #2) > - Wrap lines at 80. > > drivers/scsi/iscsi_tcp.c | 26 +++++++++--------------- > drivers/scsi/iscsi_tcp.h | 2 -- > drivers/target/iscsi/iscsi_target_util.c | 15 ++++++++------
When you send this again can you split it into 2 patches? drivers/scsi/iscsi_tcp.* is one driver. It's similar to a NFS client and it has a set of maintainers that you saw in the MAINTAINER file. drivers/target/iscsi/iscsi_target_util.c is another driver which is similar to a NFS server. Martin is the overall maintainer but it's a group effort to review patches. I've tested and reviewed the iscsi_tcp parts. You can add my: Reviewed-by: Mike Christie <michael.chris...@oracle.com> For the iscsi_target_util.c part, I'm reviewing it now and hoping Maurizio and/or Dimitry might review as well. One question on the target part I had is about the TODO above. Is that something you were going to do, or is it something you are asking the target people to do? -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/27fd3750-7b9c-9638-26d8-0df3f0e33b81%40oracle.com.
