[ 
https://issues.apache.org/jira/browse/OPENJPA-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476470
 ] 

Craig Russell commented on OPENJPA-160:
---------------------------------------

A few questions and a comment.

1. Is the profiling capturing CPU time or wait time?

2. Is the VM synchronizing on the constructor, possibly because of the 
finalize() method that needs to register with a collection? The VM might just 
synchronize before construction to avoid synchronizing later.

3. Do we really need the finalizer?

4. What about Patrick's suggestion to use clone() instead of constructing a new 
instance?

> Reuse BrokerImpl objects
> ------------------------
>
>                 Key: OPENJPA-160
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-160
>             Project: OpenJPA
>          Issue Type: Sub-task
>            Reporter: Michael Dick
>         Assigned To: Patrick Linskey
>         Attachments: newprofile.jpg, openjpa-160-patch.txt, 
> openjpa-160-patch.txt, openjpa-160-patch.txt, openjpa-160-patch.txt, 
> perf2.jpg, perf3.jpg, profile_explicitclass.jpg
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to