Tracker item #2032683, was opened at 2008-07-30 15:00 Message generated for change (Comment added) made by prusnak You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2032683&group_id=204462
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: kernel modules Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: Pavol Rusnak (prusnak) Assigned to: Nobody/Anonymous (nobody) Summary: Failed to compile with newest kernel Initial Comment: Compilation failed with new kernel make -C /usr/src/linux-2.6.26-3 O=/usr/src/linux-2.6.26-3-obj/x86_64/default/. modules CC [M] /usr/src/packages/BUILD/open-vm-tools-2008.07.01-102166/modules/linux/vmmemctl/backdoorGcc64.o CC [M] /usr/src/packages/BUILD/open-vm-tools-2008.07.01-102166/modules/linux/vmmemctl/os.o /usr/src/packages/BUILD/open-vm-tools-2008.07.01-102166/modules/linux/vmmemctl/os.c: In function 'os_init': /usr/src/packages/BUILD/open-vm-tools-2008.07.01-102166/modules/linux/vmmemctl/os.c:553: error: 'struct proc_dir_entry' has no member named 'get_info' make[6]: *** [/usr/src/packages/BUILD/open-vm-tools-2008.07.01-102166/modules/linux/vmmemctl/os.o] Error 1 This is because Linus dropped get_info from proc_dir_entry struct. See details: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8731f14d37825b54ad0c4c309cba2bc8fdf13a86 I'm not sure how to fix that. Whether to use ->read_proc and modify the callbacks or drop completely. ---------------------------------------------------------------------- >Comment By: Pavol Rusnak (prusnak) Date: 2008-08-08 14:42 Message: Logged In: YES user_id=1688417 Originator: YES Any progress? ---------------------------------------------------------------------- Comment By: Adar Dembo (adembo) Date: 2008-07-30 22:02 Message: Logged In: YES user_id=1867590 Originator: NO Thanks for reporting this bug. I've filed another bug report in our internal bugzilla so that this gets looked at more promptly. ->read_proc may be a reasonable substitute, but in the commit record you linked to Alexey says that we should put "->read_proc/->write_proc/read_proc_entry() users on death row", so it may be best to use a seq_file interface (as he recommends) instead. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2032683&group_id=204462 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ open-vm-tools-devel mailing list open-vm-tools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
