Tracker item #2071988, was opened at 2008-08-24 11:22
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2071988&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Dominique Leuenberger (dimstar)
Assigned to: Nobody/Anonymous (nobody)
Summary: Module vmci does not compile

Initial Comment:
Im trying to spin up new rpms for open-vm-tools (opensuse).

The configure uses --without-kernel-modules (as the build actually happens in a 
controlled virtual environment, not running the target kernel).

the modules themself are after built using
  #make modules
  for module in %{vm_modules}; do
    pushd modules/linux/$module
    make -C /usr/src/linux-obj/%{_target_cpu}/$flavor modules M=$PWD 
VM_CCVER=$(gcc -dumpversion) SRCROOT=$PWD
    popd
  done

vm_modules contains a list of modules to be built: "vmblock vmhgfs ... vmci"

this works (and did for long time now) for all modules, but on vmci it fails 
with the following errors:

+ for module in vmblock vmhgfs vmmemctl vmsync vmxnet vsock vmci
+ pushd modules/linux/vmci
/usr/src/packages/BUILD/obj/debug/modules/linux/vmci 
/usr/src/packages/BUILD/obj/debug /usr/src/packages/BUILD
++ gcc -dumpversion
+ make -C /usr/src/linux-obj/i586/debug modules 
M=/usr/src/packages/BUILD/obj/debug/modules/linux/vmci VM_CCVER=4.3 
SRCROOT=/usr/src/packages/BUILD/obj/debug/modules/linux/vmci
make: Entering directory `/usr/src/linux-2.6.27-rc3-2-obj/i386/debug'
make -C ../../../linux-2.6.27-rc3-2 
O=/usr/src/linux-2.6.27-rc3-2-obj/i386/debug/. modules
Using standalone build system.
/usr/src/packages/BUILD/obj/debug/modules/linux/vmci/autoconf/geninclude.c:19:28:
 error: linux/autoconf.h: No such file or directory
/usr/src/linux-2.6.27-rc3-2/scripts/Makefile.build:46: *** CFLAGS was changed 
in "/usr/src/packages/BUILD/obj/debug/modules/linux/vmci/Makefile". Fix it to 
use EXTRA_CFLAGS.  Stop.
make[2]: *** [_module_/usr/src/packages/BUILD/obj/debug/modules/linux/vmci] 
Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
make: Leaving directory `/usr/src/linux-2.6.27-rc3-2-obj/i386/debug'
error: Bad exit status from /var/tmp/rpm-tmp.23557 (%build)

I would anticipate if somebody could have a look into this. Most likely a small 
thing which I miss. The Makefile seems to be an exact copy of the one from 
vmxnet, except to the drivers name... so I really miss something.

Thank you

----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-09-03 12:25

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Glad to hear you were able to resolve the problem.

As for your patch, I'm surprised you need it at all. Couldn't you just
overload HEADER_DIR on the command line? That's what I do when I want to
build against the mainline git repo: "make
HEADER_DIR=/usr/src/git/linux-2.6/include"


----------------------------------------------------------------------

Comment By: Dominique Leuenberger (dimstar)
Date: 2008-09-03 12:20

Message:
Logged In: YES 
user_id=263934
Originator: YES

Found it...

Forgot that I have a patch for every single module Makefile in my
buildsystem. Had to add those new modules to the patch as well, and
everything is fine now.

I don't think the patch will get upstream, but for reference I attach it
hereto.

Feel free to use it or to dismiss this bug report.
Dominique
File Added: open-vm-tools-2008.09.03-kver.patch

----------------------------------------------------------------------

Comment By: Dominique Leuenberger (dimstar)
Date: 2008-08-25 01:12

Message:
Logged In: YES 
user_id=263934
Originator: YES

even having vmci built as the first (or only) module does not change
anything.

The problem seems to appear starting with kernel 2.6.25 (as I see the
module failing on openSUSE 11.0 and openSUSE_Factory).

Still, surprisingly, all other modules (except the newly added ones vmci
and vsock) 'know' that they are built in the kernel tree build system...
the new ones report to be built standalone.

To reproduce (take a kernel 2.6.27-rc3):
./configure --without-kernel-modules
cd modules/linux/vmci
make -C /usr/src/linux-obj/i586/debug modules
M=/usr/src/packages/BUILD/obj/debug/modules/linux/vmci VM_CCVER=4.3
SRCROOT=/usr/src/packages/BUILD/obj/debug/modules/linux/vmci

(with adjusted paths of course).

and in my case, this always reports using standalone build system, which
in fact is not true... this way, it should recognize the kernel 2.6 build
system.

----------------------------------------------------------------------

Comment By: Dominique Leuenberger (dimstar)
Date: 2008-08-25 00:29

Message:
Logged In: YES 
user_id=263934
Originator: YES

I'm not using the GIT tree. For the RPMs, I always use the officially
released tarballs (so in tis case 2008-08-08).

- File permissions are as in the tarball... will have to check further
wether there is a problem or not
- Environment: the script goes through a FOR loop, compiling all the
different modules. I can try to adjust the order of them, in case this
should matter. But this would be weird.

The kernel tree is sane (all modules are built against this tree, of the
entire distribution... and the problem does not only happen in one version
of the distro... so assuming that all the trees are broken sounds rude
against the distro maintainers (I know you did not mean it like that... )

So I'll change the order of the modules, having vsock and vmci before the
others... let's see what happens... I'll report back later today).

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-24 23:40

Message:
Logged In: YES 
user_id=1867590
Originator: NO

I really don't know what the problem might be. As you said, the Makefiles
are virtually identical: the only difference being the name of the driver.

Could you do some basic sanity checks:
- Make sure you haven't modified files in git, and that git's view of the
source is healthy (assuming you're using git).
- Make sure the file permissions are correct.
- Make sure you haven't set any environment variables that might affect
things.
- Make sure your kernel tree is sane.

When exactly did this start? With 2008.08.08? Or some time later?

----------------------------------------------------------------------

Comment By: Dominique Leuenberger (dimstar)
Date: 2008-08-24 11:35

Message:
Logged In: YES 
user_id=263934
Originator: YES

compared to the compilation of vmxnet, the following line is different:

vmxnet: Using 2.6.x kernel build system.    

vmci (and also vsock): Using standalone build system.

Maybe it helps.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2071988&group_id=204462

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
open-vm-tools-devel mailing list
open-vm-tools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel

Reply via email to