Tracker item #2064471, was opened at 2008-08-21 03:41 Message generated for change (Comment added) made by adembo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2064471&group_id=204462
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: toolbox Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: ven (ven9) Assigned to: Nobody/Anonymous (nobody) Summary: FEATURE:control vm recording by toolbox Initial Comment: A patch that affects both vmware-toolbox and vmware-toolbox-cmd, adding start/stop recording functionalities for them. It adds a new GuestApp routine, through vmware backdoor, to do it, a new panel for toolbox and a new command for toolbox-cmd as UI. This patch is based on 2008.08.08 release. I have already posted a version in devel mailing list, now I submit to tracker for simpler tracking. Thanks to Adar's review. More comments are welcomed. ---------------------------------------------------------------------- >Comment By: Adar Dembo (adembo) Date: 2008-09-11 01:22 Message: I've looked at your second patch, and here is another round of comments: - I'm trying to use git's workflow to incorporate your patches. To that end, could you use git-format-patch to format your patches? That way I should be able to use git-am to apply them easily (so make sure you can use git-am locally to apply them). - I'd like to see a screenshot of the new tab you've added to the gtk toolbox. I'd also appreciate a screenshot of the error presented by Toolsmain_MsgBox. - In GuestApp_ControlRecord, refer to statelogger_backdoor_def.h without the path. That way, we could move statelogger_backdoor_def.h to a new location in the future without updating this comment. - Don't bother calling out the isolation flag in RECORD_VMX_ERR. We cover them exhaustively in the product manuals, and mentioning it by name in this code will make it harder to change the name of the flag in the future. - I have some cosmetic suggestions regarding the wording in RECORD_VMX_ERR. Here's an alternative wording: "Error, the Record/Replay control operation failed. This could be for one of the following reasons:\n" \ "1. You are running an old version of a VMware product." \ "2. Your product has disabled these controls. To enable them, consult the product documentation.\n\n" \ "3. You tried to start a recording while already recording.\n\n" \ "4. You tried to stop a recording while already not recording.\n\n" ---------------------------------------------------------------------- Comment By: ven (ven9) Date: 2008-09-09 23:04 Message: Correct my typos and incorporate the new macros. Also add some informational error message. The new patch is applied after the first one. File Added: record-control2.patch ---------------------------------------------------------------------- Comment By: Adar Dembo (adembo) Date: 2008-09-03 00:02 Message: Logged In: YES user_id=1867590 Originator: NO Looks good, just two more requests out of me: - "proccess" --> "process" in GuestApp_ControlRecord. - I'm attaching statelogger_backdoor_def.h which contains a very rudimentary record of this backdoor protocol. Could you incorporate it into your patch, using its macros where appropriate? File Added: statelogger_backdoor_def.h ---------------------------------------------------------------------- Comment By: ven (ven9) Date: 2008-09-01 02:58 Message: Logged In: YES user_id=2082796 Originator: YES Any comments? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2064471&group_id=204462 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ open-vm-tools-devel mailing list open-vm-tools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
