Tracker item #1925183, was opened at 2008-03-25 06:50 Message generated for change (Settings changed) made by adembo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=989708&aid=1925183&group_id=204462
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: libraries Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Dominique Leuenberger (dimstar) Assigned to: Nobody/Anonymous (nobody) Summary: building on openSUSE fails Initial Comment: Building open-vm-tools on openSUSE up to 10.3 fails for some reasons. ./configure passes correctly, but make afterwards fails with: gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.03.19-82724\" "-DPACKAGE_STRING=\"open-vm-tools 2008.03.19-82724\"" -DPACKAGE_BUGREPORT=\"[EMAIL PROTECTED]" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.03.19-82724\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DNO_DNET=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I. -Wall -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -DVMX86_TOOLS -I /usr/src/packages/BUILD/open-vm-tools-2008.03.19-82724/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -DGLIBC_VERSION_22 -march=i586 -mtune=i686 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -O2 -DUSING_AUTOCONF=1 -MT str.lo -MD -MP -MF .deps/str.Tpo -c ../str.c -fPIC -DPIC -o .libs/str.o ../str.c:46: error: expected declaration specifiers or '...' before numeric constant ../str.c:46: error: expected ')' before '!=' token make[3]: *** [str.lo] Error 1 make[3]: Leaving directory `/usr/src/packages/BUILD/open-vm-tools-2008.03.19-82724/lib/string/shared' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/usr/src/packages/BUILD/open-vm-tools-2008.03.19-82724/lib/string' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/src/packages/BUILD/open-vm-tools-2008.03.19-82724/lib' make: *** [all-recursive] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.60982 (%build) line 46 in str.c is #ifndef _WIN32 extern int vasprintf(char **ptr, const char *f, va_list arg); >> extern int vswprintf(wchar_t *wcs, size_t maxlen, const wchar_t *format, >> va_list args); #endif If there's anything else I can provide, please let me know. ---------------------------------------------------------------------- Comment By: Adar Dembo (adembo) Date: 2008-10-13 00:41 Message: Haven't heard back from Dominique, so will assume this isn't a problem. ---------------------------------------------------------------------- Comment By: Adar Dembo (adembo) Date: 2008-09-03 12:32 Message: Logged In: YES user_id=1867590 Originator: NO The patch was committed, though Ryan took a different approach in the final patch than in the patch he posted in this bug report. Here's his changeset description (we use Perforce internally): Avoid clashing w/ glibc's vswprintf macro when _FORTIFY_SOURCE is used. When compiling with _FORTIFY_SOURCE > 0, glibc header files define vswprintf as a macro which makes use of a buffer overflow wrapper. This clashes with our str.c where, in the non-Windows case, we declare `extern int vswprintf...' This change attempts to fix this by not declaring vswprintf on platforms where it's known to already exist (glibc >= 2.2, FreeBSD >= 5.0, all supported versions of Solaris.) This addresses Open VM Tools / Sourceforge Tracker no. 1925183. Does the modified patch not address the problem? If so, could you reopen this bug report? ---------------------------------------------------------------------- Comment By: Dominique Leuenberger (dimstar) Date: 2008-09-03 12:22 Message: Logged In: YES user_id=263934 Originator: YES The patch apparently is still not included in the current code release (2008-09-03). I still have it in my build system, thus I can deploy the packages... but I think it would be good to bring that patch in the official source tree as well? ---------------------------------------------------------------------- Comment By: ECL (sopwith) Date: 2008-06-27 18:03 Message: Logged In: YES user_id=18318 Originator: NO Fixed according to Dominique. ---------------------------------------------------------------------- Comment By: Dominique Leuenberger (dimstar) Date: 2008-05-06 23:23 Message: Logged In: YES user_id=263934 Originator: YES I can confirm: for the SUSE / openSUSE Build System, this patch solved the compile errors. ---------------------------------------------------------------------- Comment By: Dominique Leuenberger (dimstar) Date: 2008-05-06 21:36 Message: Logged In: YES user_id=263934 Originator: YES Ryan, thank you very much. I added the patch and built (so far only one for testing) run and it seems to pass. I submitted it to the build system to get all packages built. I'll be able to tell later today if this worked entirely. THANK YOU ---------------------------------------------------------------------- Comment By: Ryan Beasley (rbeasley) Date: 2008-05-06 13:38 Message: Logged In: YES user_id=2047681 Originator: NO Hi, Dominique & Justin. Attached is a patch which I think will solve this problem for you. Please let us know if you need additional instructions, or if you encounter further problems. - Ryan File Added: ovt_lib_string_str_c.patch ---------------------------------------------------------------------- Comment By: Dominique Leuenberger (dimstar) Date: 2008-05-06 03:48 Message: Logged In: YES user_id=263934 Originator: YES just as info: with open-vm-tools 2008.05.02, the error is still happening. ---------------------------------------------------------------------- Comment By: Dominique Leuenberger (dimstar) Date: 2008-03-25 07:08 Message: Logged In: YES user_id=263934 Originator: YES File Added: config.log ---------------------------------------------------------------------- Comment By: Justin M. Forbes (jmforbes) Date: 2008-03-25 07:05 Message: Logged In: YES user_id=1399676 Originator: NO We are seeing the same at rPath on both rPL1 and rPL2. rPL2 is using glibc from RHEL 5 sources. I have not had time to debug just yet. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=989708&aid=1925183&group_id=204462 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ open-vm-tools-devel mailing list open-vm-tools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
