The following commit has been merged in the master branch: commit fae4003b403420d0b548920c7837a2d2b6e432ae Author: Cheyenne Wills <cwi...@sinenomine.net> Date: Mon Feb 12 09:43:29 2024 -0700
afs: Remove SRXAFSCB* protos from afs_prototypes.h The prototypes for the afscbint RPC functions (SRXAFSCB_*) implemented in afs_callback.c are defined in 2 locations, afs_protypes.h and afscbint.h (which is generated by rxgen). Remove the protoypes for the SRXAFSCB_* functions from afs_prototypes.h as they are redundant and are currently out of sync (the prototypes for SRXAFSCB_GetCellByNum() and SRXAFSCB_TellMeAboutYourself() are not present in afs_prototypes.h). Also remove a redundant prototype for afs_RXCallBackServer() which was prototyped both before and in the middle of the SRXAFSCB* prototypes. Since afs_callback.c only pulled in afs_prototypes.h and not afscbint.h, add an include for afscbint.h to ensure that the all the prototypes for the SRXAFSCB_* functions are present. The 2 functions listed above are flagged due to missing prototypes when building against a Linux 6.8 kernel (which sets the -Wmissing-declarations and -Wmissing-prototypes compiler flags as default). Linux 6.8 commit: 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f). When building against a kernel with CONFIG_WERROR=y, the build fails. Change-Id: Ieb43314cbeef444d44a3af74b4dca7a7986b54ba Reviewed-on: https://gerrit.openafs.org/15644 Reviewed-by: Mark Vitale <mvit...@sinenomine.net> Tested-by: Benjamin Kaduk <ka...@mit.edu> Reviewed-by: Benjamin Kaduk <ka...@mit.edu> src/afs/afs_callback.c | 2 ++ src/afs/afs_prototypes.h | 37 ------------------------------------- 2 files changed, 2 insertions(+), 37 deletions(-) -- OpenAFS Master Repository _______________________________________________ OpenAFS-cvs mailing list OpenAFS-cvs@openafs.org https://lists.openafs.org/mailman/listinfo/openafs-cvs