In addition to that, I suggest to enforce proper prototyping by :
--- ./ubik/,ubik.p.h 2004-11-09 18:09:41.000000000 +0100 +++ ./ubik/ubik.p.h 2004-11-25 11:55:24.572814026 +0100 @@ -354,6 +354,8 @@
extern afs_int32 ubik_ClientDestroy(struct ubik_client *aclient);
+extern afs_int32 ubik_CallIter(int (*aproc) (),struct ubik_client *aclient,afs_int32 aflags,int *apos,long p1,long p2,long p3,long p4,long p5,long p6,long p7,long p8,long p9,long p10,long p11,long p12,long p13,long p14,long p15,long p16);
+
/* ubik.c */
extern int ubik_BeginTrans(register struct ubik_dbase *dbase,
afs_int32 transMode, struct ubik_trans **transPtr);
--- ./ubik/,ubikclient.c 2004-08-25 09:09:43.000000000 +0200
+++ ./ubik/ubikclient.c 2004-11-25 10:55:34.631683987 +0100
@@ -46,7 +46,7 @@
#endif /* defined(UKERNEL) */
-afs_int32 ubik_CallIter(); + short ubik_initializationState; /* initial state is zero */
Douglas E. Engert wrote:
_______________________________________________
Jim Rees wrote:
I don't think we want to change rxgen. I guess I'll have to hold my nose
and look the other way while someone fixes all callers to pass all 16
params.
I agree, fix only what is needed at this time. [EMAIL PROTECTED] reported that the folloing fixed his problem.
There are only three calls that need to be fixed.
--- ./kauth/,admin_tools.c Wed Aug 25 02:03:39 2004 +++ ./kauth/admin_tools.c Mon Nov 22 13:03:47 2004 @@ -514,6 +514,7 @@ code = ubik_CallIter(KAM_LockStatus, conn, UPUBIKONLY, &count, name, instance, &tempwhen, /*spares */ 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0); if (code) { if (seriouserror(code)) --- ./kauth/,authclient.c Wed Aug 25 02:09:38 2004 +++ ./kauth/authclient.c Mon Nov 22 13:05:54 2004 @@ -476,7 +476,7 @@ lcode = code; code = ubik_CallIter(aproc, aclient, aflags, &count, p1, p2, p3, p4, - p5, p6, p7, p8); + p5, p6, p7, p8, 0, 0, 0, 0, 0, 0, 0); } while ((code == UNOQUORUM) || (code == UNOTSYNC) || (code == KALOCKED) || (code == -1));
--- ./libadmin/kas/,afs_kasAdmin.c Sun Dec 7 16:49:30 2003 +++ ./libadmin/kas/afs_kasAdmin.c Mon Nov 22 13:08:38 2004 @@ -718,6 +718,7 @@ tst = ubik_CallIter(KAM_LockStatus, kaserver->servers, UPUBIKONLY, &count, who->principal, who->instance, &locked, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0); if (tst == 0) { if (locked) {
_______________________________________________ OpenAFS-devel mailing list [EMAIL PROTECTED] https://lists.openafs.org/mailman/listinfo/openafs-devel
OpenAFS-devel mailing list
[EMAIL PROTECTED]
https://lists.openafs.org/mailman/listinfo/openafs-devel
