On Fri, 12 Aug 2005, Jim Rees wrote:
Looks good other than the obvious style bugs, but I have a couple questions.
Style? You actually mean that there's a consistent style in the
openafs source? ;)
Is there a coding style documented somewhere by the way?
This line:
max(cacheFiles, 1000);
Uh. Yeah. Obviously it should be:
cacheFiles = max(cacheFiles, 1000);
And why did you change the assumed average file size to 32KB? This might
actually be a good number but I wonder if you have data to back it up. I
just measured my own client cache and came up with 30.2KB so you could be
right.
If you read Jeffreys post from when we discussed this, he suggested
32kB (his cell showed 50kB avg) and since nobody complained it was
deemed that it was a good suggestion. Other data also backs that 10kB
is a little small nowadays.
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED]
---------------------------------------------------------------------------
If you want it done right, forget Microsoft.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel
