--On Monday, August 15, 2005 08:37:49 AM -0400 Jeffrey Altman <[EMAIL PROTECTED]> wrote:

Modules or applications that make use of rx must call rx_Init().
Adding rx_Init() to the PAM module is the appropriate thing to do.

While this is true in the general case, it's not how the kauth library and its applications were written. When klog is run, it defers calling rx_Init until ka_SingleServerConn / ka_AuthSpecificServersConn / ka_AuthServerConn are called, which does not occur until after des is used to do the string to key operation.

While changing this is not necessarily a bad thing, it should not be asserted that the existing code is just wrong. Another possibility for fixing this that I see is to have rxkad_global_stats_init called from rxkad_thr_stats_init through a pthread_once (hopefully, pthread_once is optimized so that once the "once" has clearly happened, it does not need to acquire a lock to determine that).

Attachment: p7sHpOQlCbemM.p7s
Description: S/MIME cryptographic signature

Reply via email to