On 10 Apr 2012, at 18:49, Garrett Wollman wrote:

> <<On Tue, 10 Apr 2012 13:45:30 -0400, Jeffrey Altman 
> <[email protected]> said:
> 
>> I don't see how requiring that builder owners demonstrate that "make
>> check" works on their system prior to adding "make check" to that system
>> in the buildbot is contrary to testing the test harnesses.
> 
> You are failing to make the fundamental distinction between testing
> that the test harnesses build, which is simple, takes very little
> time, and should just be done as a part of the normal build process,

I suspect we should add _building_ the test suite to the standard 'make all' 
target. Running it can then be the responsibility of 'make check'. This should 
give us the distinction between make sure that the test suite can build 
everywhere, and making sure that the tests actually pass.

Anyone want to write a patch that does this? We can resolve the various 
per-platform issues as buildbot reports them to us.

Cheers,

Simon.

_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel

Reply via email to