My compiler shows the following warning: -g -O2 -O3 -ggdb3 -Wall -Wshadow -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wdeclaration-after-statement -Wpointer-arith -Wwrite-strings -Wcast-align -Wbad-function-cast -Wmissing-format-attribute -Wformat=2 -Wformat-security -Wformat-nonliteral -Wno-long-long -Wno-strict-aliasing -MT logsys.o -MD -MP -MF .deps/logsys.Tpo -c -o logsys.o logsys.c logsys.c: In function ‘log_printf_to_logs’: logsys.c:411: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result logsys.c:421: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
please fix before merging. Thanks! -steve On Fri, 2009-04-17 at 16:34 +0200, Fabio M. Di Nitto wrote: > Hi all, > > this is the full patch for logsys v3 implementation and it also includes > the whole corosync porting. > > I'd also like to thank and credit Jim Meyering for his super reviews of > this patch at all stages. > > There is still some work to do to make it more robust in respect of > error checking and error report but this is good enough for inclusion > now. Patch for openais will be available once this one is cleared to > land. > > Highlights from logsys v3 take 3: > > logsys.h: > - LOG_MODE are now LOGSYS_MODE > - LOG_LEVEL are now LOGSYS_LEVEL > - SUBSYS_MAX is now LOGSYS_MAX_SUBSYS_COUNT > - SUBSYS_MAXLEN is now LOGSYS_MAX_SUBSYS_NAMELEN > - LOG_REC_END is now LOGSYS_REC_END > - Fixed a shadow warning in _logsys_system_setup declaration > - asserts will now report the caller name > > logsys.c > - Passing a NULL subsystem to a config_set will automatically change ALL > subsystems including default. > - tab format for LOGSYS_TAG table > - more char to const char conversion > - fix check from == -1 to more appropriate <= -1 or < 0 to make the code > more robust > - complete rework of logsys_config_file_set and logsys_config_file_close > that were broken by design. The new implementations use less memory and > are a lot faster to perform clone operations. > > mainconfig.c/main.c/mainconfig.h: > > - cleanup main_config struct from any logging bits (as they are > unrequired now) and rename it to ug_config (after user/group_config) as > it carries only uid/gid information at this point in time. > - make corosync_main_config_read_logging static. > > mainconfig.c: > > - move a few functions around to make them static without the need of > declarations. > - major rework of logging config read. given the new logsys config > interface, rework the whole config read -> logsys gateway to allow top > flexibility for the users. Split common code into separate static > functions and add config compatibility layer for cluster3 requirements. > (this is a lot easier to read from scratch than from within the patch). > - improve error_string usage and report back to main.c > > main.c: > > - add a desperate attempt to propagate config errors (see comments in > the code). An error in the logsys config for example will halt the > config read process. If corosync is already forked, there is no > guarantee that we can send the messages where they are expected (from > the configuration), so broadcast them everywhere we can. > > rest of the patch: > > - port everything to the new logsys API. > - align all LOG_LEVEL LOG_ to LOGSYS_LEVEL. > - update example config > - update corosync.conf.5 > - update logsys_overview.8 > - fix the few "one liner" comments spotted by Steven. > > Thanks > Fabio > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
