fix "fligh" typo looks good
regards -steve On Wed, 2009-04-22 at 10:48 +0200, Fabio M. Di Nitto wrote: > A real shared library should never use assert to detect an error, > but handle the error and report it to the user. > > logsys.h: > > drop all asserts within DECLARE. Those are executed always before main > and before an application is forked. It is safe to use fprintf and exit > here to report init errors. Also note that while a library should never > exit, the DECLARE_ macros are builtin within the application where the > use of exit is legitimate. > > util.c: > > needs to explicitly include assert.h that was sucked in via logsys.h > > logsys.c: > > - handle cutoff properly. cutoff is either == -1 or >= 0. If we have no > cutoff or cutoff is explicitly set to -1, then copy. Stop asserting as > there is no reason to. > > - don't assert if _logsys_subsys_create is invoked with a NULL subsystem > but return error. Do the same if we cannot allocate a subsystem. > > - don't assert if we have to parse more than 64 arguments, but simply > cutoff the parsing there. the function is void and there is no real easy > way to report an error there. > > main.c: > > check error returned from _logsys_subsys_create for IPC and TOTEM and > take proper action. > > Fabio > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
