On 12/21/2010 05:40 PM, Angus Salkeld wrote:
> If corosync segfaults we will leak shared memory.
>
> Signed-off-by: Angus Salkeld <asalk...@redhat.com>
> ---
> lib/cpg.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/lib/cpg.c b/lib/cpg.c
> index 0bbc61c..560e04d 100644
> --- a/lib/cpg.c
> +++ b/lib/cpg.c
> @@ -250,20 +250,11 @@ cs_error_t cpg_finalize (
> &res_lib_cpg_finalize,
> sizeof (struct res_lib_cpg_finalize));
>
> - if (error != CS_OK) {
> - goto error_put;
> - }
> -
> qb_ipcc_disconnect(cpg_inst->c);
>
> cpg_inst_finalize (cpg_inst, handle);
> hdb_handle_put (&cpg_handle_t_db, handle);
>
> - return (CPG_OK);
> -
> -error_put:
> - hdb_handle_put (&cpg_iteration_handle_t_db, handle);
> - cpg_inst->finalize = 0;
> return (error);
> }
>
The patch stream is not applying for me for some odd reason but this
patch looks questionable.
If I read this patch correctly it will end up with:
return (CPG_OK);
return (error);
_______________________________________________
Openais mailing list
Openais@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/openais
