Patch looks good.
Reviewed-by: Jan Friesse <jfrie...@redhat.com>
Previous CTS patches looks also good so also
Reviewed-by: Jan Friesse <jfrie...@redhat.com>
Regards,
Honza
Angus Salkeld wrote:
> If one node is paused it can miss a config change and
> thus report a larger old_members than expected.
>
> The solution is to use the left_nodes field.
>
> Master selection used to be "choose node with":
> 1) largest previous membership
> 2) (then as a tie-breaker) node with smallest nodeid
>
> New selection:
> 1) largest (previous #nodes - #nodes know to have left)
> 2) (then as a tie-breaker) node with smallest nodeid
>
> Signed-off-by: Angus Salkeld <asalk...@redhat.com>
> ---
> services/cpg.c | 23 ++++++++++++++++++-----
> 1 files changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/services/cpg.c b/services/cpg.c
> index a0336ed..ec509e0 100644
> --- a/services/cpg.c
> +++ b/services/cpg.c
> @@ -711,26 +711,41 @@ static int notify_lib_joinlist(
> return CPG_OK;
> }
>
> +static void downlist_log(int loglevel, const char *msg, struct downlist_msg*
> dl)
> +{
> + log_printf (loglevel,
> + "%s: sender %s; members(old:%d left:%d)",
> + msg,
> + api->totem_ifaces_print(dl->sender_nodeid),
> + dl->old_members,
> + dl->left_nodes);
> +}
> +
> static struct downlist_msg* downlist_master_choose (void)
> {
> struct downlist_msg *cmp;
> struct downlist_msg *best = NULL;
> struct list_head *iter;
> + uint32_t cmp_members;
> + uint32_t best_members;
>
> for (iter = downlist_messages_head.next;
> iter != &downlist_messages_head;
> iter = iter->next) {
>
> cmp = list_entry(iter, struct downlist_msg, list);
> + downlist_log(LOGSYS_LEVEL_DEBUG, "comparing", cmp);
> if (best == NULL) {
> best = cmp;
> continue;
> }
> + best_members = best->old_members - best->left_nodes;
> + cmp_members = cmp->old_members - cmp->left_nodes;
>
> - if (cmp->old_members < best->old_members) {
> + if (cmp_members < best_members) {
> continue;
> }
> - else if (cmp->old_members > best->old_members) {
> + else if (cmp_members > best_members) {
> best = cmp;
> }
> else if (cmp->sender_nodeid < best->sender_nodeid) {
> @@ -755,9 +770,7 @@ static void downlist_master_choose_and_send (void)
> log_printf (LOGSYS_LEVEL_INFO, "NO chosen downlist");
> return;
> }
> -
> - log_printf (LOGSYS_LEVEL_INFO, "chosen downlist from node %s",
> - api->totem_ifaces_print(stored_msg->sender_nodeid));
> + downlist_log(LOGSYS_LEVEL_INFO, "chosen downlist", stored_msg);
>
> /* send events */
> for (iter = process_info_list_head.next; iter !=
> &process_info_list_head; ) {
_______________________________________________
Openais mailing list
Openais@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/openais
