On 07/20/2011 12:48 AM, Jan Friesse wrote:
> Steven Dake wrote:
>> On 07/19/2011 08:01 AM, Jan Friesse wrote:
>>> Signed-off-by: Jan Friesse <jfrie...@redhat.com>
>>> ---
>>>  corosync.spec.in |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/corosync.spec.in b/corosync.spec.in
>>> index 37e53ed..823ad3d 100644
>>> --- a/corosync.spec.in
>>> +++ b/corosync.spec.in
>>> @@ -138,7 +138,7 @@ fi
>>>  %{_sysconfdir}/dbus-1/system.d/corosync-signals.conf
>>>  %endif
>>>  %if %{with snmp}
>>> -%(_datadir)/snmp/mibs/COROSYNC-MIB.txt
>>> +%{_datadir}/snmp/mibs/COROSYNC-MIB.txt
>>>  %endif
>>
>> does this patch change anything?
> 
> Ya, but it's very hard to spot (especially with small/bad fonts, it took
> me a while to notice it too). It changes round brackets ( ) to curly
> bracket { }. First means "execute in shell" (we really don't want to
> execute _datadir" command) and second "expand variable value" (this is
> what we want).
> 
>>
>>>  %{_initrddir}/corosync
>>>  %{_initrddir}/corosync-notifyd
>>
> 


Reviewed-by: Steven Dake <sd...@redhat.com>
_______________________________________________
Openais mailing list
Openais@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to