15.01.2011, 05:17, "Marcus D. Hanwell" <marcus.hanw...@kitware.com>: > On Jan 14, 2011, at 3:10 PM, Geoffrey Hutchison wrote: > >> On Jan 12, 2011, at 3:22 AM, Jerome Pansanel wrote: >>> It may be safe to remove visibility=hidden from CMakeLists.txt ? >>> >>> Debian builds use by default the autotools, that are not using the >>> visibility >>> parameter (therefore, it works perfectly). >> I would personally be OK with people removing visibility=hidden. I have >> seen a number of issues which appear to directly result from GCC's "auto" >> visibility settings, including "hidden." >> >> I think in the not-so-distant future, we need to make a much better effort >> to hide internal functions from public (visible) API. > > I added this support as it seemed to be useful, but if it is causing issues > then we could disable/remove it. Open Babel doesn't have a well defined > public API, but I had thought that if the Windows libraries worked then we > should be able to use the export macros defined there. > > The flag changes the default visibility to hidden, much like Windows > compilers have done for many years. This can help C++ libraries for a number > of reasons, and in my testing I didn't hit any major issues. We could also > add an option, defaulting to off. Major C++ projects such as KDE use this > quite successfully, and if it is a case of fixing up one or two classes it > would be worth looking into. > > I am surprised there are no issues on Windows - Chris, did you work around > similar issues as Windows is generally fussier about crossing DLL boundaries.
I've also experienced visibility issues with OpenBabel compiled using Intel Compiler on Linux -- Regards, Konstantin ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
