On Sat, Apr 16, 2011 at 10:04 PM, Chris Morley <c.mor...@gaseq.co.uk> wrote:
> On 16/04/2011 20:10, Tim Vandermeersch wrote:
>> Hi,
>>
>> I have two local commits with some polishing changes for the depiction
>> code and svg format. The first just makes the lines thicker and sets
>> the linecap and linejoin to round. The before and after results can be
>> seen in the first pair of images:
>>
>> Thicker lines before: http://imagebin.org/148554
>> Thicker lines after: http://imagebin.org/148555
>>
>> The second commit makes the non-ring double bonds look nicer. The
>> effect can best be seen in C=C bonds:
>>
>> C=C bond before: http://imagebin.org/148556
>> C=C bond before: http://imagebin.org/148557
>>
>> However, this change makes the =O atom in the first example look differently.
>>
>> Should I commit these changes to svn or do people prefer the old style?
>
> I prefer the symmetrical non-ring double bond, even for alkenes. The
> asymmetric double bond in rings is a convention,presumably so that there
> are regular hexagons, etc., aiding visual interpretation. The asymmetric
> alkenes get in the way for me - I am thinking, "Why is the double bond
> on that side?".

I have made this an option (-xs). The default style is unchanged now.

> svgformat produces bond widths which are different for single and
> multiple molecules; I quite like the variety. Both are lighter than your
> prosal. Of the three I just about prefer the two thinnest.

I've made this an option too (-xt). I like the thicker lines

> It's good that you have improved the line joins.

:-)

> There is a problem with hash bonds, that needs correcting:
> C(=O)N(O)CC(CCCCC)C(=O)N[C@H](C(C)(C)C)C(=O)N(C)C

Should I try to debug this?

> Chris
>
>
>
> ------------------------------------------------------------------------------
> Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve
> application availability and disaster protection. Learn more about boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> _______________________________________________
> OpenBabel-Devel mailing list
> OpenBabel-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openbabel-devel
>

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel

Reply via email to