Hi,
On Tue, Aug 28, 2012 at 12:36 AM, My Th <rei4...@gmail.com> wrote:
> P , 2012-08-27 23:22 +0200, Tim Vandermeersch rakstīja:
>> Hi,
>>
>> I have commented out the code that caused the compile problems.
>> However, I have no idea why the OBMinimizingEnergyConformerScore and
>> OBMinimizingRMSDConformerScore classes Geoff added were removed. Also
>> I added virtual destructors again but did not make them pure virtual.
>> I get a link error with pure virtual destructors and this is probably
>> the reason why they were removed. I usually just define an empty {}
>> implementation although I forgot in the original conformersearch.h
>> file.
>
> No, pure virtual destructors are just fine, you just didn't notice that
> the same commit also removed their implementations from
> src/conformersearch.cpp, they were moved there in r4869 (Fix by Reinis
> for r4832 to get rid of warning about "inconsistent dll linkage").
Yes, you are right. However, I don't see the point in adding pure
virtual destructors to a class that already has pure virtual methods.
You still need to define them in the cpp file (since doing so in the
header causes the inconsistent dll linkage error) so the optimal way
seems to define them in the class itself. The only valid use would be
to make a class abstract that has no other methods. These are details
though and I don't really care how one does this as long as it
compiles on all platforms.
Tim
>
> Reinis
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel
