On Mon, Sep 3, 2012 at 11:44 AM, Marcus D. Hanwell <marcus.hanw...@kitware.com> wrote: > Hi, > > I have been working on getting Avogadro to build on Windows for the > next release, and have hit an issue with InChI. It looks like it no > longer exports symbols on MSVC Windows builds, but that is relatively > easy to fix. I also noticed that there are two inchi_api.h files, one > in include and one in include/inchi. If I delete the one in include, > then the inchidescriptor.cpp fails to build. > > This looks like it needs InChI to be enabled, but is unconditionally > built (it includes the inchiformat header). Should the logic for the > InChI include directories be moved up from src/formats to src so that > the include directories will be set up correctly? Should we only > enable the inchi descriptor if InChI is enabled and remove the extra > inchi_api.h file in include? > Answering my own question a little, it looks like inchiformat.h has some header only InChI specific code that the descriptor file is using. It also has all the InChI formats and includes inchi_api.h meaning that InChI must be in the include path (although it is implicitly always there due to the duplicated header in the include directory of the source tree).
Wouldn't it be better to simply separate out the header only functions used by the descriptor? The other problem seems to be due to the InChI export macro changing the symbol it is looking for to invoke the declspec path, I have this working and can commit a simple patch to trunk (this is the immediate issue I needed fixing, the other can wait). Thanks, Marcus ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
