May I suggest that we replace Unset functions for flags (e.g.
UnsetAromaticPerceived()), with a parameter to the Set functions (e.g.
SetAromaticPerceived(false))? This is already the case for some of the Set
functions. This would tidy the API a bit, and ensure that we actually have
the ability to both set and unset flags (which wasn't the case for at least
some flags). I think user impact will be minimal.

If we wanted to go further, then we could replace the all of these
functions with just two: SetFlag(bits) and UnsetFlag(bits), where we would
provide an enum for the bits.

Regards,
- Noel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel

Reply via email to