details: /erp/devel/pi/rev/94bc85e2ea60 changeset: 13022:94bc85e2ea60 user: Antonio Moreno <antonio.moreno <at> openbravo.com> date: Thu Jun 30 17:09:48 2011 +0200 summary: Column headers in CSV file exported from querylist will have the correct quotes
details: /erp/devel/pi/rev/45f722ed8b0e changeset: 13023:45f722ed8b0e user: Antonio Moreno <antonio.moreno <at> openbravo.com> date: Thu Jun 30 17:10:35 2011 +0200 summary: Related to issue 16948. Added capability to also translate the 'Remove Formula Field' and 'Remove Summary Field' strings details: /erp/devel/pi/rev/e861861de87c changeset: 13024:e861861de87c user: Antonio Moreno <antonio.moreno <at> openbravo.com> date: Thu Jun 30 17:42:36 2011 +0200 summary: Related to issue 17789. Changed encoding of generated CSV files so that they work seamlessly with Excel details: /erp/devel/pi/rev/3dc747db65f2 changeset: 13025:3dc747db65f2 user: Antonio Moreno <antonio.moreno <at> openbravo.com> date: Thu Jun 30 17:57:40 2011 +0200 summary: Related to issue 17789. Changed encoding of generated CSV files so that they work seamlessly with Excel diffstat: modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java | 6 +- modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MESSAGE.xml | 22 ++++++++++ modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js | 2 + 3 files changed, 27 insertions(+), 3 deletions(-) diffs (76 lines): diff -r 0499ad7a934c -r 3dc747db65f2 modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java --- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java Thu Jun 30 17:53:54 2011 +0200 +++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java Thu Jun 30 17:57:40 2011 +0200 @@ -194,7 +194,7 @@ exportAs = "csv"; } if ("csv".equals(exportAs)) { - response.setContentType("text/csv; charset=UTF-8"); + response.setContentType("text/csv; charset=iso-8859-1"); response.setHeader("Content-Disposition", "attachment; filename=ExportedData.csv"); if (getDataSource(request) instanceof DefaultDataSourceService) { QueryJSONWriterToCSV writer = new QueryJSONWriterToCSV(request, response, parameters, @@ -241,7 +241,7 @@ Map<String, String> parameters, Entity entity) { try { OBContext.setAdminMode(); - response.setContentType("text/csv; charset=UTF-8"); + response.setContentType("text/csv; charset=iso-8859-1"); response.setHeader("Content-Disposition", "attachment; filename=ExportedData.csv"); writer = response.getWriter(); VariablesSecureApp vars = new VariablesSecureApp(request); @@ -398,7 +398,7 @@ writer.append(fieldSeparator); } keys.add(key); - writer.append("'").append(key).append("'"); + writer.append("\"").append(key).append("\""); } propertiesWritten = true; } catch (Exception e) { diff -r 0499ad7a934c -r 3dc747db65f2 modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MESSAGE.xml --- a/modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MESSAGE.xml Thu Jun 30 17:53:54 2011 +0200 +++ b/modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MESSAGE.xml Thu Jun 30 17:57:40 2011 +0200 @@ -682,6 +682,28 @@ <!--FF80808130D566F90130D57C35910012--> <AD_MODULE_ID><![CDATA[EC356CEE3D46416CA1EBEEB9AB82EDB9]]></AD_MODULE_ID> <!--FF80808130D566F90130D57C35910012--></AD_MESSAGE> +<!--FF80808130E0E1230130E10F1BDA0009--><AD_MESSAGE> +<!--FF80808130E0E1230130E10F1BDA0009--> <AD_MESSAGE_ID><![CDATA[FF80808130E0E1230130E10F1BDA0009]]></AD_MESSAGE_ID> +<!--FF80808130E0E1230130E10F1BDA0009--> <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID> +<!--FF80808130E0E1230130E10F1BDA0009--> <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID> +<!--FF80808130E0E1230130E10F1BDA0009--> <ISACTIVE><![CDATA[Y]]></ISACTIVE> +<!--FF80808130E0E1230130E10F1BDA0009--> <VALUE><![CDATA[OBUISC_ListGrid.removeFormulaFieldText]]></VALUE> +<!--FF80808130E0E1230130E10F1BDA0009--> <MSGTEXT><![CDATA[Remove Formula Field...]]></MSGTEXT> +<!--FF80808130E0E1230130E10F1BDA0009--> <MSGTYPE><![CDATA[I]]></MSGTYPE> +<!--FF80808130E0E1230130E10F1BDA0009--> <AD_MODULE_ID><![CDATA[EC356CEE3D46416CA1EBEEB9AB82EDB9]]></AD_MODULE_ID> +<!--FF80808130E0E1230130E10F1BDA0009--></AD_MESSAGE> + +<!--FF80808130E0E1230130E10F67C5000F--><AD_MESSAGE> +<!--FF80808130E0E1230130E10F67C5000F--> <AD_MESSAGE_ID><![CDATA[FF80808130E0E1230130E10F67C5000F]]></AD_MESSAGE_ID> +<!--FF80808130E0E1230130E10F67C5000F--> <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID> +<!--FF80808130E0E1230130E10F67C5000F--> <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID> +<!--FF80808130E0E1230130E10F67C5000F--> <ISACTIVE><![CDATA[Y]]></ISACTIVE> +<!--FF80808130E0E1230130E10F67C5000F--> <VALUE><![CDATA[OBUISC_ListGrid.removeSummaryFieldText]]></VALUE> +<!--FF80808130E0E1230130E10F67C5000F--> <MSGTEXT><![CDATA[Remove Summary Field...]]></MSGTEXT> +<!--FF80808130E0E1230130E10F67C5000F--> <MSGTYPE><![CDATA[I]]></MSGTYPE> +<!--FF80808130E0E1230130E10F67C5000F--> <AD_MODULE_ID><![CDATA[EC356CEE3D46416CA1EBEEB9AB82EDB9]]></AD_MODULE_ID> +<!--FF80808130E0E1230130E10F67C5000F--></AD_MESSAGE> + <!--FF8081812E05A8A6012E05AB19C80006--><AD_MESSAGE> <!--FF8081812E05A8A6012E05AB19C80006--> <AD_MESSAGE_ID><![CDATA[FF8081812E05A8A6012E05AB19C80006]]></AD_MESSAGE_ID> <!--FF8081812E05A8A6012E05AB19C80006--> <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID> diff -r 0499ad7a934c -r 3dc747db65f2 modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js --- a/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js Thu Jun 30 17:53:54 2011 +0200 +++ b/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js Thu Jun 30 17:57:40 2011 +0200 @@ -169,8 +169,10 @@ isc.ListGrid.addProperties({addFormulaFieldText: getLabel('OBUISC_ListGrid.addFormulaFieldText')}); isc.ListGrid.addProperties({editFormulaFieldText: getLabel('OBUISC_ListGrid.editFormulaFieldText')}); +isc.ListGrid.addProperties({removeFormulaFieldText: getLabel('OBUISC_ListGrid.removeFormulaFieldText')}); isc.ListGrid.addProperties({addSummaryFieldText: getLabel('OBUISC_ListGrid.addSummaryFieldText')}); isc.ListGrid.addProperties({editSummaryFieldText: getLabel('OBUISC_ListGrid.editSummaryFieldText')}); +isc.ListGrid.addProperties({removeSummaryFieldText: getLabel('OBUISC_ListGrid.removeSummaryFieldText')}); isc.ListGrid.addProperties({emptyMessage: getLabel('OBUISC_ListGrid.emptyMessage')}); isc.ListGrid.addProperties({loadingDataMessage: getLabel('OBUISC_ListGrid.loadingDataMessage')}); isc.ListGrid.addProperties({loadingMessage: ''}); // empty string is fine see description in smartclient reference getLabel('OBUISC_ListGrid.loadingMessage') ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits