details: https://code.openbravo.com/erp/devel/main/rev/20e38edb6bf0 changeset: 15703:20e38edb6bf0 user: Augusto Mauch <augusto.mauch <at> openbravo.com> date: Thu Mar 15 12:00:42 2012 +0100 summary: Fixes issue 19956: Selecters are not validated on change
The property validateOnChange of ob-selector-item has been set to false. This way, the validation of the selectors is only done when an option is selected or when the content of the selector is deleted. This change not only fixes the issue but also improves the behaviour of selectors, because prior to the fix, if a mandatory selector had text entered but no option selected, the save button was enabled. Now the save button is not enabled until an option is selected. details: https://code.openbravo.com/erp/devel/main/rev/e0024666eff8 changeset: 15704:e0024666eff8 user: Antonio Moreno <antonio.moreno <at> openbravo.com> date: Thu Mar 15 17:36:41 2012 +0100 summary: Fixed issue 20040. The DAL connection wil be committed so that the execution of the AlertProcess doesn't create a non-finishing transaction details: https://code.openbravo.com/erp/devel/main/rev/0622ea4d08c0 changeset: 15705:0622ea4d08c0 user: David Baz Fayos <david.baz <at> openbravo.com> date: Thu Mar 15 12:29:11 2012 +0100 summary: Related to issue 19545: Removed undesired log4j.error when there is no email configured diffstat: modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js | 5 ++++- src/org/openbravo/erpCommon/ad_process/AlertProcess.java | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diffs (38 lines): diff -r f3389d7ef131 -r 0622ea4d08c0 modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- a/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js Wed Mar 14 17:36:39 2012 +0100 +++ b/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js Thu Mar 15 12:29:11 2012 +0100 @@ -315,7 +315,10 @@ autoFetchData: false, showPickerIcon: true, - validateOnChange: true, + // selectors should not be validated on change, only after its content has been deleted + // and after an option of the combo has been selected + // see issue 19956 (https://issues.openbravo.com/view.php?id=19956) + validateOnChange: false, completeOnTab: true, // note validateonexit does not work when completeOnTab is true // setting it anyway, the this.validate() is called in the blur diff -r f3389d7ef131 -r 0622ea4d08c0 src/org/openbravo/erpCommon/ad_process/AlertProcess.java --- a/src/org/openbravo/erpCommon/ad_process/AlertProcess.java Wed Mar 14 17:36:39 2012 +0100 +++ b/src/org/openbravo/erpCommon/ad_process/AlertProcess.java Thu Mar 15 12:29:11 2012 +0100 @@ -85,6 +85,8 @@ } } catch (Exception e) { throw new JobExecutionException(e.getMessage(), e); + } finally { + OBDal.getInstance().commitAndClose(); } } @@ -163,9 +165,7 @@ .getInstance().get(Client.class, adClientId))); final List<EmailServerConfiguration> mailConfigList = mailConfigCriteria.list(); - if (mailConfigList.size() == 0) { - log4j.error("No Poc configuration found for this client."); - } else { + if (mailConfigList.size() > 0) { // TODO: There should be a mechanism to select the desired Email server configuration // for alerts, until then, first search for the current organization (and use the // first returned one), then for organization '0' (and use the first returned one) and ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
