details: https://code.openbravo.com/erp/devel/pi/rev/c7615d4c36ac changeset: 16753:c7615d4c36ac user: Mikel Irurita <mikel.irurita <at> openbravo.com> date: Tue Jun 05 15:59:54 2012 +0200 summary: Fixes issue 20673: RFC/RTV (pick&edit): error product without attribute set instance
details: https://code.openbravo.com/erp/devel/pi/rev/b93e89d8bd60 changeset: 16754:b93e89d8bd60 user: Mikel Irurita <mikel.irurita <at> openbravo.com> date: Tue Jun 05 16:02:14 2012 +0200 summary: Fixes issue 20680: RFC/RTV (pick&edit): error when returning a line diffstat: src/org/openbravo/common/actionhandler/SRMOPickEditLines.java | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diffs (26 lines): diff -r f91001dc95e5 -r b93e89d8bd60 src/org/openbravo/common/actionhandler/SRMOPickEditLines.java --- a/src/org/openbravo/common/actionhandler/SRMOPickEditLines.java Tue Jun 05 15:34:12 2012 +0200 +++ b/src/org/openbravo/common/actionhandler/SRMOPickEditLines.java Tue Jun 05 16:02:14 2012 +0200 @@ -144,8 +144,11 @@ ShipmentInOutLine shipmentLine = OBDal.getInstance().get(ShipmentInOutLine.class, selectedLine.getString("goodsShipmentLine")); Product product = OBDal.getInstance().get(Product.class, selectedLine.getString("product")); - AttributeSetInstance asi = OBDal.getInstance().get(AttributeSetInstance.class, - selectedLine.get("attributeSetValue")); + AttributeSetInstance asi = null; + String asiParam = selectedLine.getString("attributeSetValue"); + if (!"null".equals(asiParam)) { + asi = OBDal.getInstance().get(AttributeSetInstance.class, asiParam); + } UOM uom = OBDal.getInstance().get(UOM.class, selectedLine.get("uOM")); newOrderLine.setGoodsShipmentLine(shipmentLine); @@ -174,7 +177,7 @@ } // tax String taxId = selectedLine.getString("tax"); - if (taxId == null) { + if ("null".equals(taxId)) { List<Object> parameters = new ArrayList<Object>(); parameters.add(product.getId()); ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits