details:   https://code.openbravo.com/erp/devel/pi/rev/c85e2fa57fa1
changeset: 27019:c85e2fa57fa1
user:      Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
date:      Wed Jun 17 19:17:55 2015 +0200
summary:   Fixes issue 30185: AlertsForWrongOrders modulescript generates wrong 
alerts

The query of the modulescript did not take into account the isinvoicepaid 
status (if the payment was paid or not) to check if the amount of the 
paymentschedule was correct.

diffstat:

 
modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.class
                |    0 
 
modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrders_data.xsql
    |    4 ++--
 
modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.java
 |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diffs (35 lines):

diff -r 1d10b6a08a30 -r c85e2fa57fa1 
modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.class
Binary file 
modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.class
 has changed
diff -r 1d10b6a08a30 -r c85e2fa57fa1 
modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrders_data.xsql
--- 
a/modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrders_data.xsql
   Tue Jun 23 14:46:54 2015 +0000
+++ 
b/modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrders_data.xsql
   Wed Jun 17 19:17:55 2015 +0200
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <!--
  
************************************************************************************
- * Copyright (C) 2014 Openbravo S.L.U.
+ * Copyright (C) 2014-2015 Openbravo S.L.U.
  * Licensed under the Openbravo Commercial License version 1.0
  * You may obtain a copy of the License at 
http://www.openbravo.com/legal/obcl.html
  * or in the legal folder of this module distribution.
@@ -18,7 +18,7 @@
       from c_order, fin_payment_schedule, fin_payment_scheduledetail 
       where c_order.c_order_id = fin_payment_schedule.c_order_id
       and fin_payment_schedule.fin_payment_schedule_id = 
fin_payment_scheduledetail.fin_payment_schedule_order 
-      and fin_payment_scheduledetail.iscanceled = 'N' 
+      and fin_payment_scheduledetail.isinvoicepaid = 'Y'
       and fin_payment_scheduledetail.fin_payment_detail_id IS NOT NULL 
       group by fin_payment_schedule.ad_org_id, 
fin_payment_schedule.ad_client_id, c_order.issotrx, 
fin_payment_schedule.fin_payment_schedule_id, 
       fin_payment_schedule.c_order_id, fin_payment_schedule.paidamt 
diff -r 1d10b6a08a30 -r c85e2fa57fa1 
modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.java
--- 
a/modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.java
        Tue Jun 23 14:46:54 2015 +0000
+++ 
b/modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/AlertsForWrongOrdersData.java
        Wed Jun 17 19:17:55 2015 +0200
@@ -63,7 +63,7 @@
       "      from c_order, fin_payment_schedule, fin_payment_scheduledetail " +
       "      where c_order.c_order_id = fin_payment_schedule.c_order_id" +
       "      and fin_payment_schedule.fin_payment_schedule_id = 
fin_payment_scheduledetail.fin_payment_schedule_order " +
-      "      and fin_payment_scheduledetail.iscanceled = 'N' " +
+      "      and fin_payment_scheduledetail.isinvoicepaid = 'Y'" +
       "      and fin_payment_scheduledetail.fin_payment_detail_id IS NOT NULL 
" +
       "      group by fin_payment_schedule.ad_org_id, 
fin_payment_schedule.ad_client_id, c_order.issotrx, 
fin_payment_schedule.fin_payment_schedule_id, " +
       "      fin_payment_schedule.c_order_id, fin_payment_schedule.paidamt " +

------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to