details: https://code.openbravo.com/erp/devel/pi/rev/2ec4bfb5b7c9 changeset: 28019:2ec4bfb5b7c9 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Thu Nov 12 14:34:31 2015 +0100 summary: Fixes issue 31452: Avoid log @APRM_INVALID_TRANSACTION@ exception in error mode
Avoid log @APRM_INVALID_TRANSACTION@ exception in error mode in FIN_FinaccTransactionEventListener.validateTransactionType method, and do it in debug mode instead. This will avoid unstable executions when running APRM automated tests. details: https://code.openbravo.com/erp/devel/pi/rev/c3fce2ec13d9 changeset: 28020:c3fce2ec13d9 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Thu Nov 12 14:45:02 2015 +0100 summary: Related to issue 31452: Avoid log @APRM_PaymentNoLines@ exception in error mode Avoid log @APRM_PaymentNoLines@ exception in error mode in FIN_PaymentProcess.processPayment method, and do it in debug mode instead. This will avoid unstable executions when running APRM automated tests. details: https://code.openbravo.com/erp/devel/pi/rev/8a03fc30c8e3 changeset: 28021:8a03fc30c8e3 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Thu Nov 12 14:52:08 2015 +0100 summary: Related to issue 31452: Avoid log @PeriodNotAvailable@ exception in error mode Avoid log @PeriodNotAvailable@ exception in error mode in AddPaymentActionHandler.createNewPayment method, and do it in debug mode instead. This will avoid unstable executions when running APRM automated tests. diffstat: modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java | 3 ++- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_FinaccTransactionEventListener.java | 7 +++++-- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diffs (64 lines): diff -r 8ae08a1890a3 -r 8a03fc30c8e3 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java Wed Nov 18 11:15:28 2015 +0100 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java Thu Nov 12 14:52:08 2015 +0100 @@ -281,7 +281,8 @@ strDocBaseType, org.getId(), OBDateUtils.formatDate(paymentDate)) && orgLegalWithAccounting) { String messag = OBMessageUtils.messageBD("PeriodNotAvailable"); - throw new OBException(messag); + log.debug(messag); + throw new OBException(messag, false); } String strPaymentAmount = "0"; diff -r 8ae08a1890a3 -r 8a03fc30c8e3 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_FinaccTransactionEventListener.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_FinaccTransactionEventListener.java Wed Nov 18 11:15:28 2015 +0100 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_FinaccTransactionEventListener.java Thu Nov 12 14:52:08 2015 +0100 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2014 Openbravo SLU + * All portions are Copyright (C) 2014-2015 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -22,6 +22,7 @@ import javax.enterprise.event.Observes; import org.apache.commons.lang.StringUtils; +import org.apache.log4j.Logger; import org.openbravo.advpaymentmngt.utility.APRMConstants; import org.openbravo.base.exception.OBException; import org.openbravo.base.model.Entity; @@ -38,6 +39,7 @@ private static Entity[] entities = { ModelProvider.getInstance().getEntity( FIN_FinaccTransaction.ENTITY_NAME) }; + protected Logger logger = Logger.getLogger(this.getClass()); @Override protected Entity[] getObservedEntities() { @@ -79,7 +81,8 @@ .equals(transactionType, APRMConstants.TRXTYPE_BPWithdrawal)) && glItem == null && payment == null) { - throw new OBException("@APRM_INVALID_TRANSACTION@"); + logger.debug("@APRM_INVALID_TRANSACTION@"); + throw new OBException("@APRM_INVALID_TRANSACTION@", false); } } } diff -r 8ae08a1890a3 -r 8a03fc30c8e3 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java Wed Nov 18 11:15:28 2015 +0100 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java Thu Nov 12 14:52:08 2015 +0100 @@ -217,7 +217,8 @@ // Show error message when payment has no lines if (paymentDetails.size() == 0) { msg = OBMessageUtils.messageBD("APRM_PaymentNoLines"); - throw new OBException(msg); + log4j.debug(msg); + throw new OBException(msg, false); } for (FIN_PaymentDetail paymentDetail : paymentDetails) { for (FIN_PaymentScheduleDetail paymentScheduleDetail : paymentDetail ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
