details: https://code.openbravo.com/erp/devel/pi/rev/a8a6d8bd52e5 changeset: 29706:a8a6d8bd52e5 user: Sanjota <sanjota.nelagi <at> promantia.com> date: Mon Jun 13 20:23:15 2016 +0530 summary: Fixes issue 27432: Cleanup unused variables in pl-functions & triggers
There are quite a few variables declared in in pl-functions & -triggers which are never used, found using static analysis using plpgsql_check. Clean those variables details: https://code.openbravo.com/erp/devel/pi/rev/a3c288cd3d2f changeset: 29707:a3c288cd3d2f user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Mon Jun 27 18:59:29 2016 +0200 summary: Related to issue 27432: Code review improvements diffstat: modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml | 3 - modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_ISPAYMENTCONFIRMED.xml | 4 +- src-db/database/model/functions/A_ASSET_CREATE.xml | 3 +- src-db/database/model/functions/A_ASSET_POST.xml | 8 +---- src-db/database/model/functions/C_AGING_GET_SCOPE.xml | 4 +- src-db/database/model/functions/C_BANKSTATEMENT_POST.xml | 8 +---- src-db/database/model/functions/C_BP_GROUP_ACCT_COPY.xml | 6 +-- src-db/database/model/functions/C_CASH_POST.xml | 4 +- src-db/database/model/functions/C_CHANGEPROJECTSTATUS.xml | 3 +- src-db/database/model/functions/C_CHANGEPROJECTSTATUSTOORDER.xml | 4 +- src-db/database/model/functions/C_CLOSEPROJECT.xml | 3 +- src-db/database/model/functions/C_CURRENCY_CONVERT.xml | 4 +- src-db/database/model/functions/C_CURRENCY_CONVERT_RATE.xml | 4 +- src-db/database/model/functions/C_CURRENCY_RATE.xml | 6 +-- src-db/database/model/functions/C_DB_PERCENTAGE_PAID.xml | 3 +- src-db/database/model/functions/C_DP_MANAGEMENT_POST.xml | 12 +------ src-db/database/model/functions/C_GENERATEPOFROMPROJECT.xml | 3 +- src-db/database/model/functions/C_GENERATESOFROMPROJECT.xml | 4 +- src-db/database/model/functions/C_GENERATESOFROMPROJECTPHASE.xml | 4 +- src-db/database/model/functions/C_GET_IBAN_DISPLAYED_ACCOUNT.xml | 5 +-- src-db/database/model/functions/C_GET_NET_PRICE_FROM_GROSS.xml | 3 +- src-db/database/model/functions/C_INVOICELINETAX_INSERT.xml | 8 +---- src-db/database/model/functions/C_INVOICELINETAX_ROUNDING.xml | 3 +- src-db/database/model/functions/C_INVOICE_POST.xml | 5 +-- src-db/database/model/functions/C_ORDERLINETAX_INSERT.xml | 8 +---- src-db/database/model/functions/C_ORDERLINETAX_ROUNDING.xml | 3 +- src-db/database/model/functions/C_ORDER_POST1.xml | 5 -- src-db/database/model/functions/C_ORDER_PO_CREATE.xml | 4 +- src-db/database/model/functions/C_PAYINADVANCE_CREATE.xml | 5 +-- src-db/database/model/functions/C_PERIOD_PROCESS.xml | 3 +- src-db/database/model/functions/C_PROJECT_GENERATE.xml | 5 +- src-db/database/model/functions/C_REMITTANCE_POST.xml | 7 +--- src-db/database/model/functions/C_SETTLEMENT_POST.xml | 5 +-- src-db/database/model/functions/C_TAXPAYMENT_POST.xml | 17 +-------- src-db/database/model/functions/C_TAX_GET_LEVEL.xml | 3 +- src-db/database/model/functions/C_VALIDCOMBINATION_CLONE.xml | 6 --- src-db/database/model/functions/C_YEARPERIODS.xml | 3 +- src-db/database/model/functions/FACT_ACCT_RESET.xml | 3 +- src-db/database/model/functions/MA_COPY_VERSION.xml | 1 - src-db/database/model/functions/MA_GLOBALUSE_DISTRIBUTE.xml | 7 +-- src-db/database/model/functions/MA_MAINTENANCE_SCHEDULE.xml | 3 +- src-db/database/model/functions/MA_MEASURE_SHIFT_EXPLODE.xml | 4 +- src-db/database/model/functions/MA_MEASURE_TIME_EXPLODE.xml | 3 +- src-db/database/model/functions/MA_PC_CASE_CREATE.xml | 3 +- src-db/database/model/functions/MA_PRODUCTIONRUN_STANDARD.xml | 1 - src-db/database/model/functions/MA_PRODUCTION_COST.xml | 7 +--- src-db/database/model/functions/MA_PRODUCTION_COST_GENERATE.xml | 3 +- src-db/database/model/functions/MA_STANDARD_COST_SEQUENCE.xml | 3 +- src-db/database/model/functions/MRP_PROCESSPLAN.xml | 5 +-- src-db/database/model/functions/MRP_PROCESSPLAN_PLAN.xml | 5 +-- src-db/database/model/functions/MRP_PROCESSPLAN_RECALCULATE.xml | 5 +-- src-db/database/model/functions/MRP_PROCESSPLAN_RECALCULATE0.xml | 3 +- src-db/database/model/functions/MRP_PRODUCTION_RUN.xml | 3 +- src-db/database/model/functions/MRP_PURCHASEORDER.xml | 3 - src-db/database/model/functions/MRP_PURCHASEPLAN.xml | 5 +-- src-db/database/model/functions/MRP_PURCHASE_RUN.xml | 3 +- src-db/database/model/functions/MRP_REQUISITION.xml | 3 +- src-db/database/model/functions/MRP_RUN_EXPLODE.xml | 6 +-- src-db/database/model/functions/MRP_RUN_INITIALIZE.xml | 5 +-- src-db/database/model/functions/MRP_WORKREQUIREMENT.xml | 7 +--- src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml | 4 +- src-db/database/model/functions/M_GENERATE_AVERAGE_COSTS.xml | 1 - src-db/database/model/functions/M_GENERATE_STANDARD_COSTS.xml | 1 - src-db/database/model/functions/M_GET_OFFERS_NAME.xml | 3 +- src-db/database/model/functions/M_GET_PARETO_ABC.xml | 3 +- src-db/database/model/functions/M_GET_PARETO_ABC_LEGACY.xml | 3 +- src-db/database/model/functions/M_GET_STOCK.xml | 3 +- src-db/database/model/functions/M_GET_STOCK_PARAM.xml | 6 +-- src-db/database/model/functions/M_INOUTEXPLODEBOMNOTSTOCK.xml | 5 +-- src-db/database/model/functions/M_INOUT_CANCEL.xml | 3 +- src-db/database/model/functions/M_INOUT_CREATE.xml | 1 - src-db/database/model/functions/M_INOUT_CREATEINVOICE.xml | 1 - src-db/database/model/functions/M_INOUT_POST.xml | 7 ---- src-db/database/model/functions/M_INTERNAL_CONSUMPTION_POST1.xml | 3 +- src-db/database/model/functions/M_INVENTORY_POST.xml | 4 +- src-db/database/model/functions/M_MOVEMENT_POST.xml | 3 +- src-db/database/model/functions/M_RAPPEL_INVOICE_CREATE.xml | 4 +- src-db/database/model/functions/M_REQUISITION_CREATEPO.xml | 3 +- src-db/database/model/functions/M_RESERVATION_REALLOCATE.xml | 2 - src-db/database/model/functions/M_UNIQUELOCATOR_RULE.xml | 3 +- src-db/database/model/functions/M_UNIQUELOCATOR_RULE_PARAM.xml | 3 +- src-db/database/model/functions/M_UPDATE_PARETO_PRODUCT.xml | 3 +- src-db/database/model/functions/M_UPDATE_PARETO_PRODUCT_LEGACY.xml | 3 +- src-db/database/model/functions/S_TIMEEXPENSE_POST.xml | 4 +- 84 files changed, 81 insertions(+), 274 deletions(-) diffs (truncated from 1965 to 300 lines): diff -r 4d95296ddea7 -r a3c288cd3d2f modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml --- a/modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml Mon Jun 27 18:59:29 2016 +0200 @@ -61,8 +61,6 @@ v_delete_paymentplan BOOLEAN := FALSE; v_Financial_Account_ID FIN_FINANCIAL_ACCOUNT.FIN_FINANCIAL_ACCOUNT_ID%TYPE; v_Financial_Account_Org VARCHAR2(32); -v_CreatePayment CHAR(1):='N'; -v_CreateFinTransaction CHAR(1):='N'; v_PaymentDocType_ID FIN_PAYMENT.C_DOCTYPE_ID%TYPE; v_PaymentDocumentNo FIN_PAYMENT.DOCUMENTNO%TYPE; v_FIN_PAYMENT_ID FIN_PAYMENT.FIN_PAYMENT_ID%TYPE; @@ -93,7 +91,6 @@ cur_PaymentScheduleOrder RECORD; cur_linktopayment_scheddetails RECORD; cur_update_scheddetails RECORD; -cur_invoicepaid RECORD; v_paymentamt NUMBER:=0; v_depositamt NUMBER:=0; diff -r 4d95296ddea7 -r a3c288cd3d2f modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_ISPAYMENTCONFIRMED.xml --- a/modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_ISPAYMENTCONFIRMED.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_ISPAYMENTCONFIRMED.xml Mon Jun 27 18:59:29 2016 +0200 @@ -19,20 +19,18 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU -* All portions are Copyright (C) 2011-2015 Openbravo SLU +* All portions are Copyright (C) 2011-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************/ v_Sql VARCHAR2(2000); v_count NUMBER; v_module VARCHAR2(32); - v_dbprefix VARCHAR2(7); v_isPaymentConfirmed CHAR(1) := 'N'; v_isinvoicepaid CHAR(1):= 'N'; v_referencelist VARCHAR2(32):='575BCB88A4694C27BC013DE9C73E6FE7'; TYPE RECORD IS REF CURSOR; Cur_Dbprefix RECORD; - v_invoicepaidstatus VARCHAR2(32); v_fin_payment_schedule_order VARCHAR(32); v_fin_payment_schedule_invoice VARCHAR(32); v_p_fin_psd_id VARCHAR(32); diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/A_ASSET_CREATE.xml --- a/src-db/database/model/functions/A_ASSET_CREATE.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/A_ASSET_CREATE.xml Mon Jun 27 18:59:29 2016 +0200 @@ -22,7 +22,7 @@ * parts created by ComPiere are Copyright (C) ComPiere, Inc.; * All Rights Reserved. * Contributor(s): Openbravo SLU - * Contributions are Copyright (C) 2001-2008 Openbravo, S.L.U. + * Contributions are Copyright (C) 2001-2016 Openbravo, S.L.U. * * Specifically, this derivative work is based upon the following Compiere * file and version. @@ -49,7 +49,6 @@ Cur_ShipLine RECORD; -- v_A_Asset_ID VARCHAR2(32) ; - v_A_Asset_Delivery_ID VARCHAR2(32) ; v_DocumentNo VARCHAR2(40) ; v_Value VARCHAR2(60) ; v_Name VARCHAR2(80) ; diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/A_ASSET_POST.xml --- a/src-db/database/model/functions/A_ASSET_POST.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/A_ASSET_POST.xml Mon Jun 27 18:59:29 2016 +0200 @@ -19,7 +19,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU -* All portions are Copyright (C) 2001-2012 Openbravo SLU +* All portions are Copyright (C) 2001-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************/ @@ -34,12 +34,8 @@ Cur_Parameter RECORD; -- Record Info v_count NUMBER; - v_UpdatedBy A_ASSET.UpdatedBy%TYPE; v_Processing A_ASSET.Processing%TYPE; v_Processed A_ASSET.Processed%TYPE; - v_DateAcct DATE; - v_DocumentNo A_ASSET.DocumentNo%TYPE; - BPartner_ID VARCHAR2(32); v_ACCTVALUEAMT NUMBER; v_AD_CLIENT_ID VARCHAR2(32); v_AD_ORG_ID VARCHAR2(32); @@ -62,11 +58,9 @@ v_ORIGUSELIFEYEARS NUMBER; v_ASSETSCHEDULE VARCHAR2(60) ; v_TOTAL_DAYS NUMBER; - v_THIS_YEAR_DAYS NUMBER; v_BEGINING_DATE DATE; v_ENDING_DATE DATE; v_AUXAMT NUMBER; - v_AMORTIZATIONAMT NUMBER; v_NEW_AMORTIZATION VARCHAR2(32); v_LINE NUMBER; v_SEQ_ASSET NUMBER; diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_AGING_GET_SCOPE.xml --- a/src-db/database/model/functions/C_AGING_GET_SCOPE.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_AGING_GET_SCOPE.xml Mon Jun 27 18:59:29 2016 +0200 @@ -28,7 +28,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU -* All portions are Copyright (C) 2008 Openbravo SLU +* All portions are Copyright (C) 2008-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************/ @@ -37,7 +37,7 @@ * In case the DATE is i.e. 28/02/2007 this function will return 28/03/2007 * while add_moths returns 31/03/2007 ************************************************************************/ - pDateAux DATE; + BEGIN if (pDate<now()) then return 0; diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_BANKSTATEMENT_POST.xml --- a/src-db/database/model/functions/C_BANKSTATEMENT_POST.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_BANKSTATEMENT_POST.xml Mon Jun 27 18:59:29 2016 +0200 @@ -19,7 +19,7 @@ * parts created by ComPiere are Copyright (C) ComPiere, Inc.; * All Rights Reserved. * Contributor(s): Openbravo SLU - * Contributions are Copyright (C) 2001-2009 Openbravo, S.L.U. + * Contributions are Copyright (C) 2001-2016 Openbravo, S.L.U. * * Specifically, this derivative work is based upon the following Compiere * file and version. @@ -32,7 +32,6 @@ ************************************************************************/ -- Logistice v_ResultStr VARCHAR2(2000):=''; - v_Result NUMBER; v_Message VARCHAR2(2000):=''; v_Record_ID VARCHAR2(32); v_User VARCHAR2(32); @@ -43,7 +42,6 @@ v_C_Debt_Payment_ID VARCHAR2(32); v_documentno_Settlement VARCHAR2(40); v_documentno_Dp_Management VARCHAR2(50); - v_column_identifier VARCHAR2(200); v_dateSettlement DATE; v_Cancel_Processed VARCHAR(60); v_nameBankstatement VARCHAR2 (60); @@ -137,9 +135,6 @@ DECLARE Cur_AutomaticSettlementCancel RECORD; CUR_MANAGEMENTLINES RECORD; - v_DP_MANAGEMENT NUMBER; - v_DATEACCT DATE; - v_DATETRX DATE; BEGIN /* * Reversing process @@ -661,7 +656,6 @@ */ DECLARE v_Total NUMBER:=0; - v_Currency_ID VARCHAR2(32):=NULL; -- Lines Cur_Lines RECORD; BEGIN diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_BP_GROUP_ACCT_COPY.xml --- a/src-db/database/model/functions/C_BP_GROUP_ACCT_COPY.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_BP_GROUP_ACCT_COPY.xml Mon Jun 27 18:59:29 2016 +0200 @@ -25,7 +25,7 @@ * parts created by ComPiere are Copyright (C) ComPiere, Inc.; * All Rights Reserved. * Contributor(s): Openbravo SLU - * Contributions are Copyright (C) 2001-2009 Openbravo, S.L.U. + * Contributions are Copyright (C) 2001-2016 Openbravo, S.L.U. * * Specifically, this derivative work is based upon the following Compiere * file and version. @@ -41,8 +41,6 @@ v_ResultStr VARCHAR2(2000):=''; v_Message VARCHAR2(2000):=''; v_Record_ID VARCHAR2(32); - v_IsProcessing CHAR(1) ; - v_IsProcessed VARCHAR(60) ; v_myResult NUMBER:=1; -- Success -- Parameter TYPE RECORD IS REF CURSOR; @@ -51,8 +49,6 @@ v_C_BP_Group_ID VARCHAR2(32); v_C_AcctSchema_ID VARCHAR2(32); -- A Group can only have one client - Cur_Acct RECORD; - Cur_BPartner RECORD; Cur_BP RECORD; -- v_Deleted NUMBER:=0; diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_CASH_POST.xml --- a/src-db/database/model/functions/C_CASH_POST.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_CASH_POST.xml Mon Jun 27 18:59:29 2016 +0200 @@ -20,7 +20,7 @@ * parts created by ComPiere are Copyright (C) ComPiere, Inc.; * All Rights Reserved. * Contributor(s): Openbravo SLU - * Contributions are Copyright (C) 1999-2009 Openbravo, S.L.U. + * Contributions are Copyright (C) 1999-2016 Openbravo, S.L.U. ************************************************************************* * $Id: C_Cash_Post.sql,v 1.10 2003/03/17 20:32:25 jjanke Exp $ *** @@ -37,7 +37,6 @@ v_Record_ID VARCHAR2(32) ; v_User VARCHAR2(32); v_C_Debt_Payment_ID VARCHAR2(32); - v_C_Order_ID VARCHAR2(32); --Added by P.SAROBE v_documentno_Settlement VARCHAR2(40); v_dateSettlement DATE; @@ -74,7 +73,6 @@ v_CB_Date DATE; v_AD_Org_ID VARCHAR2(32); v_AD_Client_ID VARCHAR2(32); - v_C_Settlement_ID VARCHAR2(32); v_C_CashBook_ID VARCHAR2(32) ; FINISH_PROCESS BOOLEAN:=false; BEGIN diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_CHANGEPROJECTSTATUS.xml --- a/src-db/database/model/functions/C_CHANGEPROJECTSTATUS.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_CHANGEPROJECTSTATUS.xml Mon Jun 27 18:59:29 2016 +0200 @@ -16,7 +16,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU -* All portions are Copyright (C) 2001-2009 Openbravo SLU +* All portions are Copyright (C) 2001-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************/ @@ -31,7 +31,6 @@ cur_parameter RECORD; v_p_projectstatus VARCHAR(60); v_projectstatus VARCHAR(60); - v_created NUMBER:= 0; finish_process BOOLEAN := FALSE; BEGIN -- Get Parameters diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_CHANGEPROJECTSTATUSTOORDER.xml --- a/src-db/database/model/functions/C_CHANGEPROJECTSTATUSTOORDER.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_CHANGEPROJECTSTATUSTOORDER.xml Mon Jun 27 18:59:29 2016 +0200 @@ -16,7 +16,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU -* All portions are Copyright (C) 2001-2015 Openbravo SLU +* All portions are Copyright (C) 2001-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************/ @@ -33,12 +33,10 @@ v_ProjectStatus VARCHAR(60) ; v_projectcategory VARCHAR(60); v_temppricelist VARCHAR(60); - v_Created NUMBER:=0; v_PriceListVersion varchar2(32); v_PriceList varchar2(32); v_PriceListVersionPO varchar2(32); v_PriceListPO varchar2(32); - v_C_Currency_ID VARCHAR2(32); v_TotalPhases NUMBER; v_TotalLines NUMBER; v_BPName VARCHAR2(2000):=''; diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_CLOSEPROJECT.xml --- a/src-db/database/model/functions/C_CLOSEPROJECT.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_CLOSEPROJECT.xml Mon Jun 27 18:59:29 2016 +0200 @@ -16,7 +16,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU -* All portions are Copyright (C) 2001-2009 Openbravo SLU +* All portions are Copyright (C) 2001-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************/ @@ -30,7 +30,6 @@ v_ProjectStatus VARCHAR(60) ; v_projectcategory VARCHAR(60); v_temppricelist VARCHAR(60); - v_Created NUMBER:=0; FINISH_PROCESS BOOLEAN:=false; BEGIN -- Update AD_PInstance diff -r 4d95296ddea7 -r a3c288cd3d2f src-db/database/model/functions/C_CURRENCY_CONVERT.xml --- a/src-db/database/model/functions/C_CURRENCY_CONVERT.xml Mon Jun 27 11:46:23 2016 +0000 +++ b/src-db/database/model/functions/C_CURRENCY_CONVERT.xml Mon Jun 27 18:59:29 2016 +0200 @@ -37,7 +37,7 @@ * parts created by ComPiere are Copyright (C) ComPiere, Inc.; * All Rights Reserved. * Contributor(s): Openbravo SLU -* Contributions are Copyright (C) 2001-2010 Openbravo, S.L.U. ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
