[OpenbravoERP-commits] devel/pi: Fixed 33789. Avoid accidental double query by not call...

[hg]

details:   https://code.openbravo.com/erp/devel/pi/rev/3d8d5b58f0ec
changeset: 29891:3d8d5b58f0ec
user:      Stefan Hühner <stefan.huehner <at> openbravo.com>
date:      Wed Aug 24 11:08:58 2016 +0200
summary:   Fixed 33789. Avoid accidental double query by not calling .list() 
twice

diffstat:

 src/org/openbravo/service/db/CallProcess.java |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (27 lines):

diff -r a064f77cbfb9 -r 3d8d5b58f0ec 
src/org/openbravo/service/db/CallProcess.java
--- a/src/org/openbravo/service/db/CallProcess.java     Wed Aug 24 10:12:12 
2016 +0200
+++ b/src/org/openbravo/service/db/CallProcess.java     Wed Aug 24 11:08:58 
2016 +0200
@@ -25,6 +25,7 @@
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
 import java.util.Date;
+import java.util.List;
 import java.util.Map;
 import java.util.Properties;
 
@@ -85,12 +86,13 @@
         .createCriteria(org.openbravo.model.ad.ui.Process.class);
     
processCriteria.add(Restrictions.eq(org.openbravo.model.ad.ui.Process.PROPERTY_PROCEDURE,
         processName));
-    if (processCriteria.list().size() != 1) {
+    List<org.openbravo.model.ad.ui.Process> processList = 
processCriteria.list();
+    if (processList.size() != 1) {
       throw new OBException("No process or more than one process found using 
procedurename "
           + processName);
 
     }
-    return call(processCriteria.list().get(0), recordID, parameters, doCommit);
+    return call(processList.get(0), recordID, parameters, doCommit);
   }
 
   /**

------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits