details: https://code.openbravo.com/erp/devel/pi/rev/e909d7e193e5
changeset: 29955:e909d7e193e5
user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
date: Wed Aug 31 11:11:13 2016 +0200
summary: Related to issue 33771: Code review improvements
Use uniqueResult() == null instead of list().isEmpty(), adding setMaxResults(1)
to avoid exceptions.
Update copyright.
diffstat:
src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diffs (24 lines):
diff -r 938e3500425d -r e909d7e193e5
src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java
--- a/src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java Mon Aug
29 15:25:51 2016 +0200
+++ b/src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java Wed Aug
31 11:11:13 2016 +0200
@@ -11,7 +11,7 @@
* under the License.
* The Original Code is Openbravo ERP.
* The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2001-2015 Openbravo SLU
+ * All portions are Copyright (C) 2001-2016 Openbravo SLU
* All Rights Reserved.
* Contributor(s): ______________________________________.
************************************************************************
@@ -404,9 +404,10 @@
.eq(FinAccPaymentMethod.PROPERTY_PAYMENTMETHOD,
selectedPaymentMethod));
obc.add(Restrictions.in(FinAccPaymentMethod.PROPERTY_ORGANIZATION +
".id", OBContext
.getOBContext().getOrganizationStructureProvider().getNaturalTree(strOrgId)));
+ obc.setMaxResults(1);
// filter is on unique constraint so list().size() <=1 always
- if (obc.list().isEmpty()) {
+ if (obc.uniqueResult() == null) {
message = Utility.messageBD(this,
"PaymentmethodNotbelongsFinAccount",
vars.getLanguage());
}
------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
