details: https://code.openbravo.com/erp/devel/pi/rev/e46e66b4f219 changeset: 29997:e46e66b4f219 user: Gorka Ion Damián <gorkaion.damian <at> openbravo.com> date: Tue Sep 06 12:25:45 2016 +0200 summary: Fixes issue 33909. Add null check on closeSession
On some very specific scenarios it is possible to execute 2 commitAndClose or rollbacks on the same SessionHandler instance. As both methods calls the setSession(null) and closeSession() methods a NPE is thrown on the second execution. diffstat: src/org/openbravo/dal/core/SessionHandler.java | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diffs (14 lines): diff -r 89eaadd3beda -r e46e66b4f219 src/org/openbravo/dal/core/SessionHandler.java --- a/src/org/openbravo/dal/core/SessionHandler.java Wed Sep 07 09:23:12 2016 +0200 +++ b/src/org/openbravo/dal/core/SessionHandler.java Tue Sep 06 12:25:45 2016 +0200 @@ -208,7 +208,9 @@ } protected void closeSession() { - session.close(); + if (session != null && session.isOpen()) { + session.close(); + } } /** ------------------------------------------------------------------------------ _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits