details: https://code.openbravo.com/erp/devel/pi/rev/985e8955ab63
changeset: 30321:985e8955ab63
user: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
date: Tue Sep 27 16:32:05 2016 +0200
summary: Fixes issue 34033: Removed unnecessary check in manageComboData
method.
diffstat:
src/org/openbravo/erpCommon/ad_callouts/SimpleCalloutInformationProvider.java
| 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diffs (24 lines):
diff -r 65f08702a333 -r 985e8955ab63
src/org/openbravo/erpCommon/ad_callouts/SimpleCalloutInformationProvider.java
---
a/src/org/openbravo/erpCommon/ad_callouts/SimpleCalloutInformationProvider.java
Tue Sep 27 16:26:36 2016 +0200
+++
b/src/org/openbravo/erpCommon/ad_callouts/SimpleCalloutInformationProvider.java
Tue Sep 27 16:32:05 2016 +0200
@@ -89,8 +89,8 @@
@Override
public Boolean isComboData(Object element) {
if (element instanceof JSONObject) {
- JSONObject json = (JSONObject) element;
- return json.has(CalloutConstants.ENTRIES);
+ JSONObject comboElement = (JSONObject) element;
+ return comboElement.has(CalloutConstants.ENTRIES);
}
return false;
}
@@ -143,8 +143,6 @@
changedCols.add(col.getDBColumnName());
}
- if (entry.has(CalloutConstants.ENTRIES)) {
- selectedEntry.put(CalloutConstants.ENTRIES, newJsonArr);
- }
+ selectedEntry.put(CalloutConstants.ENTRIES, newJsonArr);
}
}
------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
