details:   https://code.openbravo.com/erp/devel/pi/rev/fd9a0c5fcb36
changeset: 30642:fd9a0c5fcb36
user:      Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
date:      Mon Nov 14 18:01:08 2016 +0100
summary:   Related to issue 26499: Code review improvements

diffstat:

 
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournalLine.java
 |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (26 lines):

diff -r de43b28a3df5 -r fd9a0c5fcb36 
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournalLine.java
--- 
a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournalLine.java
  Sat Nov 12 18:18:08 2016 -0500
+++ 
b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPaymentFromJournalLine.java
  Mon Nov 14 18:01:08 2016 +0100
@@ -72,8 +72,8 @@
 
       // Check restrictions
       OBContext.setAdminMode(false);
-      if (!journalLine.getJournalEntry().isMultigeneralLedger()) {
-        try {
+      try {
+        if (!journalLine.getJournalEntry().isMultigeneralLedger()) {
           final StringBuilder hsqlScript = new StringBuilder();
           hsqlScript.append("select distinct(o.generalLedger) ");
           hsqlScript.append("from Organization o ");
@@ -85,9 +85,9 @@
           if (query.list().size() != 1) {
             throw new OBException("@FIN_NoMultiAccountingAllowed@");
           }
-        } finally {
-          OBContext.restorePreviousMode();
         }
+      } finally {
+        OBContext.restorePreviousMode();
       }
 
       if (!journalLine.getCurrency().equals(financialAccount.getCurrency())) {

------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to