details:   https://code.openbravo.com/erp/devel/pi/rev/5e4e6352a9f7
changeset: 31641:5e4e6352a9f7
user:      Carlos Aristu <carlos.aristu <at> openbravo.com>
date:      Fri Mar 10 14:37:32 2017 +0100
summary:   related to issue 35426: improved comments

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
 |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (21 lines):

diff -r 62fc67af48c0 -r 5e4e6352a9f7 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
   Fri Mar 10 12:13:30 2017 +0100
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
   Fri Mar 10 14:37:32 2017 +0100
@@ -574,13 +574,13 @@
     }
   },
 
-  // for Table reference the displayProperty is used in the filtering criteria 
instead of OB.Constants.IDENTIFIER
-  // see issue https://issues.openbravo.com/view.php?id=30800
+  // for Table references the property name used in the criteria depends on 
the type of filtering
+  // when the filtering is done in the server, the displayProperty is used
+  // on adaptive filtering (client side), OB.Constants.IDENTIFIER is used
   getDisplayProperty: function () {
     var theGrid = this.grid,
         name = this.name;
-    // it is used willFetchData to identified when adaptive filtering is not 
occurred.
-    // see issue https://issues.openbravo.com/view.php?id=35426
+    // Use willFetchData() to identify whether we are performing adaptive 
filtering
     if (theGrid && name && theGrid.getField(name) && 
theGrid.getField(name).displayProperty && 
this.form.grid.sourceWidget.willFetchData()) {
       return name + OB.Constants.FIELDSEPARATOR + 
theGrid.getField(name).displayProperty;
     }

------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to