details: https://code.openbravo.com/erp/devel/pi/rev/bf199b193c83 changeset: 32323:bf199b193c83 user: Inigo Sanchez <inigo.sanchez <at> openbravo.com> date: Tue Jun 20 01:31:01 2017 +0200 summary: Fixed issue 33833: Products can not be added to node from popup
Products can not be added to node from popup because an IndexOutOfBoundsException is thrown. To avoid this problem a check is added. Besides another check is added in order to avoid a NPE. details: https://code.openbravo.com/erp/devel/pi/rev/540e39d05914 changeset: 32324:540e39d05914 user: Inigo Sanchez <inigo.sanchez <at> openbravo.com> date: Tue Jun 20 01:33:48 2017 +0200 summary: Related with issue 33833: Applied JSBeautifier properly diffstat: modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js | 7 +++++-- modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diffs (36 lines): diff -r 5cd8c36d0974 -r 540e39d05914 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js Mon Jun 19 14:23:31 2017 +0000 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js Tue Jun 20 01:33:48 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2014-2016 Openbravo SLU + * All portions are Copyright (C) 2014-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************ @@ -66,7 +66,10 @@ } // Check validation rules (subordinated fields), when value of a // parent field is changed, all its subordinated are reset - affectedParams = this.paramWindow.dynamicColumns[item.name]; + var dynamicColumns = this.paramWindow.dynamicColumns; + if (dynamicColumns && dynamicColumns[item.name]) { + affectedParams = dynamicColumns[item.name]; + } if (affectedParams) { for (i = 0; i < affectedParams.length; i++) { field = this.getField(affectedParams[i]); diff -r 5cd8c36d0974 -r 540e39d05914 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js Mon Jun 19 14:23:31 2017 +0000 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js Tue Jun 20 01:33:48 2017 +0200 @@ -222,7 +222,7 @@ tab.setTitle(OB.I18N.getLabel('OBUIAPP_ProcessTitle_Done', [this.tabTitle])); } - if (data.showResultsInProcessView) { + if (data && data.showResultsInProcessView) { if (!this.resultLayout) { this.resultLayout = isc.HLayout.create({ width: '100%', ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
