details:   https://code.openbravo.com/erp/devel/pi/rev/3f6b96e0cba9
changeset: 32375:3f6b96e0cba9
user:      Carlos Aristu <carlos.aristu <at> openbravo.com>
date:      Tue Jun 27 20:12:37 2017 +0200
summary:   related to issue 33833: code review improvements

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js
 |  6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diffs (25 lines):

diff -r f3b0864cfcb5 -r 3f6b96e0cba9 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js
      Tue Jun 27 12:20:36 2017 +0000
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-form.js
      Tue Jun 27 20:12:37 2017 +0200
@@ -55,7 +55,7 @@
   // this function is invoked on the blur action of the formitems
   // this is the proper place to execute the client-side callouts
   handleItemChange: function (item) {
-    var affectedParams, i, field, me = this,
+    var dynamicColumns, affectedParams, i, field, me = this,
         registryId;
 
     registryId = this.paramWindow.viewId || this.paramWindow.processId;
@@ -66,11 +66,9 @@
     }
     // Check validation rules (subordinated fields), when value of a
     // parent field is changed, all its subordinated are reset
-    var dynamicColumns = this.paramWindow.dynamicColumns;
+    dynamicColumns = this.paramWindow.dynamicColumns;
     if (dynamicColumns && dynamicColumns[item.name]) {
       affectedParams = dynamicColumns[item.name];
-    }
-    if (affectedParams) {
       for (i = 0; i < affectedParams.length; i++) {
         field = this.getField(affectedParams[i]);
         if (field && field.setValue) {

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to