details: https://code.openbravo.com/erp/devel/pi/rev/b8a0e333c8f2 changeset: 32425:b8a0e333c8f2 user: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> date: Fri Jul 07 09:11:46 2017 +0200 summary: Fixed issue 36430: Cleanup bad logging (printStackTrace, System.*.print.*)
Pushed on Stefan's behalf Removed usage of printStackTrace and System.*.print.* and tranform them to log4j.error details: https://code.openbravo.com/erp/devel/pi/rev/918cd718f0f3 changeset: 32426:918cd718f0f3 user: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> date: Fri Jul 07 09:36:56 2017 +0200 summary: Fixed issue 36430: Cleanup bad logging (printStackTrace, System.*.print.*) Replaced to log.error() calls where necessary details: https://code.openbravo.com/erp/devel/pi/rev/47aab9353bb6 changeset: 32427:47aab9353bb6 user: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> date: Fri Jul 07 09:39:49 2017 +0200 summary: Fixed issue 36430: removed bad usage even in examples details: https://code.openbravo.com/erp/devel/pi/rev/b4290824ae05 changeset: 32428:b4290824ae05 user: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> date: Fri Jul 07 10:43:24 2017 +0200 summary: Fixed issue 36436: Avoid using Vector<Object> for single type of data Changeset pushed on Stefan's behalf diffstat: modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddTransaction.java | 7 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java | 20 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java | 9 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/BatchPaymentExecution.java | 9 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/Transactions.java | 8 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_reports/ReportReconciliation.java | 6 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java | 3 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java | 5 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java | 6 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProposalProcess.java | 6 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ReconciliationProcess.java | 6 +- modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionModify.java | 6 +- modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.java | 8 +- src/org/openbravo/common/hooks/InventoryStatusValidationHook.java | 2 +- src/org/openbravo/common/hooks/OrderLineQtyChangedHook.java | 5 +- src/org/openbravo/erpCommon/ad_process/CreateTaxReport.java | 13 +- src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java | 34 ++-- src/org/openbravo/erpCommon/businessUtility/AccountTree.java | 64 +++++----- src/org/openbravo/erpCommon/businessUtility/COAUtility.java | 4 +- src/org/openbravo/erpCommon/businessUtility/Tax.java | 28 +---- 20 files changed, 115 insertions(+), 134 deletions(-) diffs (truncated from 941 to 300 lines): diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddTransaction.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddTransaction.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddTransaction.java Fri Jul 07 10:43:24 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2010-2014 Openbravo SLU + * All portions are Copyright (C) 2010-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -31,6 +31,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.apache.log4j.Logger; import org.codehaus.jettison.json.JSONException; import org.codehaus.jettison.json.JSONObject; import org.hibernate.criterion.Restrictions; @@ -77,6 +78,7 @@ public class AddTransaction extends HttpSecureAppServlet { private static final long serialVersionUID = 1L; private AdvPaymentMngtDao dao; + private static final Logger log = Logger.getLogger(AddTransaction.class); public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { @@ -171,8 +173,7 @@ out.close(); } catch (JSONException e) { - - e.printStackTrace(); + log.error("Error building json output", e); } } diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java Fri Jul 07 10:43:24 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2010-2014 Openbravo SLU + * All portions are Copyright (C) 2010-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -361,8 +361,8 @@ return ((FIN_ReconciliationLine_v) obc.uniqueResult()).getTransactionDate(); } - private void printPage(HttpServletResponse response, VariablesSecureApp variables, String strOrgId, - String strWindowId, String strTabId, String strPaymentTypeFilter, + private void printPage(HttpServletResponse response, VariablesSecureApp variables, + String strOrgId, String strWindowId, String strTabId, String strPaymentTypeFilter, String strFinancialAccountId, String reconciliationId, String strShowCleared, String strHideDate) throws IOException, ServletException { log4j @@ -403,8 +403,8 @@ xmlDocument.setParameter("paramPaymentTypeFilter", strPaymentTypeFilter); xmlDocument.setParameter("showCleared", strShowCleared); xmlDocument.setParameter("hideDate", strHideDate); - xmlDocument.setParameter("jsDateFormat", "var sc_JsDateFormat =\"" + variables.getJsDateFormat() - + "\";"); + xmlDocument.setParameter("jsDateFormat", + "var sc_JsDateFormat =\"" + variables.getJsDateFormat() + "\";"); // Check if There is a matching algorithm for the given financial account FIN_FinancialAccount financial = OBDal.getInstance().get(FIN_FinancialAccount.class, strFinancialAccountId); @@ -414,7 +414,8 @@ } catch (Exception ex) { OBDal.getInstance().rollbackAndClose(); OBError message = Utility.translateError(this, variables, variables.getLanguage(), Utility - .parseTranslation(this, variables, variables.getLanguage(), "@APRM_MissingMatchingAlgorithm@")); + .parseTranslation(this, variables, variables.getLanguage(), + "@APRM_MissingMatchingAlgorithm@")); variables.setMessage(strTabId, message); printPageClosePopUp(response, variables, Utility.getTabURL(strTabId, "R", true)); return; @@ -452,12 +453,11 @@ try { OBContext.setAdminMode(true); // long init = System.currentTimeMillis(); - data = getMatchedBankStatementLinesData(variables, strFinancialAccountId, strReconciliationId, - strPaymentTypeFilter, strShowCleared, strHideDate, executeMatching); + data = getMatchedBankStatementLinesData(variables, strFinancialAccountId, + strReconciliationId, strPaymentTypeFilter, strShowCleared, strHideDate, executeMatching); // log4j.error("Getting Grid Data: " + (System.currentTimeMillis() - init)); } catch (Exception e) { - log4j.debug("Output: Exception ocurred while retrieving Bank Statement Lines.", e); - e.printStackTrace(); + log4j.error("Output: Exception ocurred while retrieving Bank Statement Lines.", e); } finally { OBContext.restorePreviousMode(); } diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java Fri Jul 07 10:43:24 2017 +0200 @@ -333,8 +333,7 @@ OBDal.getInstance().save(dummyPayment); } catch (final Exception e) { log4j.error("Exception while creating dummy payment for the invoice: " - + strC_Invoice_ID); - e.printStackTrace(); + + strC_Invoice_ID, e); } finally { OBContext.restorePreviousMode(); } @@ -515,8 +514,7 @@ } } catch (final Exception e) { log4j.error("Exception while creating dummy payment for the invoice: " - + strC_Invoice_ID); - e.printStackTrace(); + + strC_Invoice_ID, e); } finally { OBContext.restorePreviousMode(); } @@ -781,8 +779,7 @@ } } catch (final Exception e) { - log4j.error("Exception while canceling the credit in the invoice: " + strC_Invoice_ID); - e.printStackTrace(); + log4j.error("Exception while canceling the credit in the invoice: " + strC_Invoice_ID, e); } finally { OBContext.restorePreviousMode(); } diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/BatchPaymentExecution.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/BatchPaymentExecution.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/BatchPaymentExecution.java Fri Jul 07 10:43:24 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2010-2012 Openbravo SLU + * All portions are Copyright (C) 2010-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -342,8 +342,7 @@ strOrderByProperty, strAscDesc, isReceipt); } catch (ServletException e) { - log4j.error("Error in print page data: " + e); - e.printStackTrace(); + log4j.error("Error in print page data: ", e); OBError myError = Utility.translateError(this, vars, vars.getLanguage(), e.getMessage()); if (!myError.isConnectionAvailable()) { bdErrorAjax(response, "Error", "Connection Error", "No database connection"); @@ -357,14 +356,14 @@ description = myError.getMessage(); } } catch (Exception e) { - log4j.debug("Error obtaining rows data"); + log4j.error("Error obtaining rows data", e); type = "Error"; title = "Error"; if (e.getMessage().startsWith("<![CDATA[")) description = "<![CDATA[" + e.getMessage() + "]]>"; else description = e.getMessage(); - e.printStackTrace(); + } } if (!type.startsWith("<![CDATA[")) diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/Transactions.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/Transactions.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/Transactions.java Fri Jul 07 10:43:24 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2010-2011 Openbravo SLU + * All portions are Copyright (C) 2010-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -452,8 +452,7 @@ pageSize, offset, strOrderBy); // strNumRows = Integer.toString(finaccTransactions.size()); } catch (ServletException e) { - log4j.error("Error in print page data: " + e); - e.printStackTrace(); + log4j.error("Error in print page data: ", e); OBError myError = Utility.translateError(this, vars, vars.getLanguage(), e.getMessage()); if (!myError.isConnectionAvailable()) { bdErrorAjax(response, "Error", "Connection Error", "No database connection"); @@ -467,14 +466,13 @@ description = myError.getMessage(); } } catch (Exception e) { - log4j.debug("Error obtaining rows data"); + log4j.error("Error obtaining rows data", e); type = "Error"; title = "Error"; if (e.getMessage().startsWith("<![CDATA[")) description = "<![CDATA[" + e.getMessage() + "]]>"; else description = e.getMessage(); - e.printStackTrace(); } } diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_reports/ReportReconciliation.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_reports/ReportReconciliation.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_reports/ReportReconciliation.java Fri Jul 07 10:43:24 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2010-2015 Openbravo SLU + * All portions are Copyright (C) 2010-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -32,6 +32,7 @@ import net.sf.jasperreports.engine.JRException; import net.sf.jasperreports.engine.JasperReport; +import org.apache.log4j.Logger; import org.hibernate.criterion.ProjectionList; import org.hibernate.criterion.Projections; import org.hibernate.criterion.Restrictions; @@ -51,6 +52,7 @@ public class ReportReconciliation extends HttpSecureAppServlet { private static final long serialVersionUID = 1L; + private static final Logger log = Logger.getLogger(ReportReconciliation.class); final static String DETAIL = "DETAIL"; final static String SUMMARY = "SUMMARY"; @@ -340,7 +342,7 @@ BigDecimal totals = getTransactionsTotalAfterReconciliationEndDate(recon); balance = recon.getAccount().getCurrentBalance().subtract(totals); } catch (Exception e) { - e.printStackTrace(); + log.error("Error during getBalanceOfAccount", e); } finally { OBContext.restorePreviousMode(); } diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java Fri Jul 07 10:43:24 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2010-2016 Openbravo SLU + * All portions are Copyright (C) 2010-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -192,7 +192,6 @@ paymentId); } } catch (final Exception e) { - e.printStackTrace(System.err); throw new OBException(e); } finally { OBContext.restorePreviousMode(); diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java Fri Jul 07 10:43:24 2017 +0200 @@ -4,6 +4,7 @@ import java.util.Date; import java.util.List; +import org.apache.log4j.Logger; import org.hibernate.criterion.Restrictions; import org.openbravo.advpaymentmngt.dao.MatchTransactionDao; import org.openbravo.advpaymentmngt.utility.FIN_Utility; @@ -24,6 +25,8 @@ public class FIN_BankStatementProcess implements org.openbravo.scheduling.Process { + private static final Logger log = Logger.getLogger(FIN_BankStatementProcess.class); + @Override public void execute(ProcessBundle bundle) throws Exception { OBError msg = new OBError(); @@ -128,7 +131,7 @@ bundle.setResult(msg); } catch (Exception e) { - e.printStackTrace(System.err); + log.error("Error while executing FIN_BankStatementProcess", e); msg.setType("Error"); msg.setTitle(Utility.messageBD(bundle.getConnection(), "Error", bundle.getContext() .getLanguage())); diff -r 36b24dd5e2ff -r b4290824ae05 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java Fri Jul 07 12:28:04 2017 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java Fri Jul 07 10:43:24 2017 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
