details: https://code.openbravo.com/erp/devel/pi/rev/e862781be5c3
changeset: 32528:e862781be5c3
user: Armaignac <collazoandy4 <at> gmail.com>
date: Wed Jul 26 17:24:11 2017 -0400
summary: Fixes issue 36534: Error in Costing Background Process
Error in Costing Background Process if starting date of first costing rule is
lower than movement date of existing transactions.
Now, when defining the first costing rule with a non empty starting date, all
transactions with a transaction process date (instead of movement date) prior
to that date will be calculated at a zero cost.
Also, transaction process date (instead of movement date), will be taken into
account to get the stock when creating closing and opening costing rule
inventories.
diffstat:
src/org/openbravo/costing/CostingRuleProcess.java | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diffs (31 lines):
diff -r 7f51d68f998c -r e862781be5c3
src/org/openbravo/costing/CostingRuleProcess.java
--- a/src/org/openbravo/costing/CostingRuleProcess.java Wed Aug 02 14:11:51
2017 +0200
+++ b/src/org/openbravo/costing/CostingRuleProcess.java Wed Jul 26 17:24:11
2017 -0400
@@ -306,7 +306,7 @@
insert.append(" left join t." +
MaterialTransaction.PROPERTY_GOODSSHIPMENTLINE + " as iol");
insert.append(" left join iol." +
ShipmentInOutLine.PROPERTY_SHIPMENTRECEIPT + " as io");
insert.append(" where t." + MaterialTransaction.PROPERTY_ORGANIZATION +
".id in (:orgs)");
- insert.append(" and t." + MaterialTransaction.PROPERTY_MOVEMENTDATE + " <
:date");
+ insert.append(" and t." +
MaterialTransaction.PROPERTY_TRANSACTIONPROCESSDATE + " < :date");
insert.append(" and t." + MaterialTransaction.PROPERTY_ISPROCESSED + " =
false");
insert.append(" and t." + MaterialTransaction.PROPERTY_ACTIVE + " = true");
insert.append(" and t." + MaterialTransaction.PROPERTY_CLIENT + ".id =
:client");
@@ -328,7 +328,7 @@
update.append(", " + MaterialTransaction.PROPERTY_CURRENCY + " =
:currency");
update.append(", " + MaterialTransaction.PROPERTY_ISPROCESSED + " = true");
update.append(" where " + MaterialTransaction.PROPERTY_ORGANIZATION + ".id
in (:orgs)");
- update.append(" and " + MaterialTransaction.PROPERTY_MOVEMENTDATE + " <
:date");
+ update.append(" and " +
MaterialTransaction.PROPERTY_TRANSACTIONPROCESSDATE + " < :date");
update.append(" and " + MaterialTransaction.PROPERTY_ISPROCESSED + " =
false");
update.append(" and " + MaterialTransaction.PROPERTY_ACTIVE + " = true");
update.append(" and " + MaterialTransaction.PROPERTY_CLIENT + ".id =
:client");
@@ -460,7 +460,8 @@
select.append(" join trx." + MaterialTransaction.PROPERTY_STORAGEBIN +
" as loc");
select.append(" where trx." + MaterialTransaction.PROPERTY_ORGANIZATION +
".id in (:orgs)");
if (date != null) {
- select.append(" and trx." + MaterialTransaction.PROPERTY_MOVEMENTDATE
+ " < :date");
+ select.append(" and trx." +
MaterialTransaction.PROPERTY_TRANSACTIONPROCESSDATE
+ + " < :date");
}
select.append(" and trx." + MaterialTransaction.PROPERTY_PRODUCT +
".productType = 'I'");
select.append(" and trx." + MaterialTransaction.PROPERTY_PRODUCT +
".stocked = true");
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
