details:   https://code.openbravo.com/erp/devel/pi/rev/a7149d379ac1
changeset: 34792:a7149d379ac1
user:      Javier Armendáriz <javier.armendariz <at> openbravo.com>
date:      Mon Sep 24 10:25:19 2018 +0200
summary:   Fixed issue 38159: Memory leak in referenced inventory unbox process

The leak is caused by an invalid call of fireOnPause method on selector
with a targetRecordId (when clicking from the looking glass icon of a field).
This call gives an invalid delay value that causes the timeout to be called
indefinitely.

diffstat:

 
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
 |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (14 lines):

diff -r 59a0e798d44c -r a7149d379ac1 
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
--- 
a/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
      Fri Sep 21 11:05:53 2018 +0000
+++ 
b/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
      Mon Sep 24 10:25:19 2018 +0200
@@ -180,7 +180,9 @@
             rowNum = this.getRecordIndex(record);
             this.selectSingleRecord(record);
             // give grid time to draw
-            this.fireOnPause('scrollRecordIntoView', 
this.scrollRecordIntoView, [rowNum, true], this);
+            this.fireOnPause('scrollRecordIntoView_' + rowNum, function () {
+              this.scrollRecordIntoView(rowNum, true);
+            });
             delete this.targetRecordId;
           } else if (this.data.lengthIsKnown() && this.data.getLength() === 1) 
{
             // only one record, select that one straight away


_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to