Hi Isma,
Thank you for your explanations. Let me point you where I disagree.
Firstly, quickbuild is a great idea, but I'll just focus in this
specific change of externalizing core, wad and trl while keeping their
source files.
As said, I'd find it to be a good idea to include the jars in lib, as long as
the core, wad and trl projects are taken out of the trunk.
> -hide complexity to most openbravo developers (99% of them do not care about
> the three subprojects code, they will not change a line of code there)
For me it is much more confusing this way. Developers will ask: why
include the jar files and source files? In what way are we hiding
complexity? The src-{core,wad,trl} source directories are still there.
If the process now needs an extra explanation I don't find it less
complex.
> 1.- If jars are included source code should be removed from the repository:
> Fully agree but it is not quite simple because of crossed dependencies. As we
> have a tight schedule I think it makes sense to postpone this process to a
> early project in 2.60
Martin says the day to day build tasks will not depend any more on core, wad
and trl. Could you explain which crossed dependencies are those?
As I see it both sentences cannot be true for 2.50. If you are not going
to call to the core,wad,trl tasks then there is nothing depending on
them and src-{core,wad,trl} can be moved out of trunk. And on the contrary,
if there are tasks depending on them then those tasks are going to be called.
If removing the crossed dependencies would be too complicated right now,
doesn't it make more sense to wait and do both changes at the same time?
Isn't it better to do this changes after 2.50 and not when the product
is in alpha state?
In my opinion the core, trl and wad compilation time is not the
bottleneck. Sure, the compilation will take 2-10 seconds less every time.
It is really as important as to do changes half-ways and not to do the
changes we'd really would like to make?
> 2.- The time it takes is irrelevant in the whole process:
> I don't agree. If we succeed in the project the average of a quickbuild will
> be around 40 seconds and usually less than 20 seconds. With the fix done by
> Stefan to build the three libraries takes 2 seconds (so from 5 to 10%) BUT
> only if there has not been changes in code. If changes have happened then it
> takes 20 seconds that 99% of the people should skip
I clearly see quickbuild's speed benefits, I think it is great. But I'm
talking specifically about core-wad-trl and in my opinion this is not
the bottleneck. I don't think it worth it as much as to create
confusion (it does for me).
> 4.- Managing commits for this three projects is a mess
> I don't think it is so complicated. Once the jar's are included in the
> repository the svn client will realize changes there. Most of the times only
> three people need to take care about this
As I understand it, if the src-{core,wad,trl} directories are there it
means that those tasks are going to be called at some point. If they are
called, it means that the openbravo{core,wad,trl}.jar files will be
created, and will be shown as modified in the working copy. Unless they
are added to the svn:ignore, and this change will force to do it strange
operations to commit new version of the 3 files (3 commits).
So summarizing, my main point is that this change would be coherent if
the src-{core,wad,trl} directories were taken out and that in my opinion
this is not the right moment to do these kind of changes.
Juan Pablo
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Openbravo-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-development
