To view a readable diff check the diff between 12c30a4b5d14 and 1c3767f18498. The file was formatted first and reformated to the original one finally. So it was difficult to understand the original diff. This is it: http://dpaste.com/97118/
Juan Pablo On 10:48 Wed 23 Sep , Ismael Ciordia, Openbravo wrote: > Rafa, > > if you look at the old implementation, the method to update used entries in > ad_text_interfaces uses an ugly (and wrong) sql -> min ad_text_interface_id > from the union of candidates: that text in that module for that file, that > text in that module without a specific file, that text in other indevelopment > module for that file, that text in other indevelopment module without a > specific file. > > As a result, when there is an entry in ad_text_interfaces that is specific > for a file and there is another entry with the same text, generic for all > files and smaller id that entry was not marked as used (I realize the > explanation is tricky, but it is what it is :-) > > Antonio's refactoring is just proper implementation of that sql: first > updates an entry with that text in that module for that file, if no entry is > updated then updates an entry for that text in that module without a specific > file, and so on. > > Hope it satisfies your curiosity :-) > > Ismael > > > > -----Mensaje original----- > De: Rafa Roda @ Openbravo [mailto:[email protected]] > Enviado el: miércoles, 23 de septiembre de 2009 6:28 > Para: [email protected] > Asunto: Re: [Openbravo-development][DB-Consistency-Check]-ERP-pi-pgsql-full > > [Still Failing!] > > > Hi Isma and Antonio, > > > 2009/9/22 Ismael Ciordia, Openbravo <[email protected]> > > the translation process had a poor implementation to find used entries in > text > interfaces. He has refactored it and now the result is always consistent: > those three lines are actually used and they will not be marked as unused > anymore. > > > Just for curiosity, can you please clarify this or point to the issue? I'm > surprised because the translation process has been working fine for many time. > > Thank you. > > Rafa > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Openbravo-development mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openbravo-development ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Openbravo-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-development
