On 07/08/2010 11:56 PM, Nico Golde wrote: > > I adjusted the copyright stanza in these files but I'm not > completely sure if this is appropriate or not, so feel free > to remove, I won't be offended :)
The rule of thumb I heard is that anything above four lines of code is copyrightable, so your addition is totally fine! I do have two nitpicks though. We do not indent the case labels inside a switch statement and the other is more important to me, and might ask you to write a decoder, could you please update the encoding/decoding and add the string that could not be decoded by the current code? thanks