> We generate "conv.h" and put it into the source directory?

Actually, no. We aren't generate the "conv.h".
It's written manually and contains the conv_test_vector
structure definition and the do_check() function definition.

One was introduced by: https://gerrit.osmocom.org/#/c/1627/
so now the same test logic is used in two different tests
(both conv and conv_gsm0503) without code duplication.

Don't you confuse it with the "gsm0503.h", which is exactly
generated by the "utils/conv_gen.py"?

With best regards,
Vadim Yanitskiy.

2017-05-01 2:56 GMT+07:00 Holger Freyther <[email protected]>:

>
> > On 30. Apr 2017, at 10:02, Vadim Yanitskiy <[email protected]> wrote:
> >
> > It seems, I already found one solution. You're right, "build dir != src
> dir"
> > was the problem, so I added this:
> >
> > conv_conv_gsm0503_test_CPPFLAGS = \
> >     $(AM_CPPFLAGS) \
> >     -I$(top_srcdir)/tests/conv
> >
> > And now everything is fine!
>
> We generate "conv.h" and put it into the source directory? From 10.000
> miles aways it sounds a bit odd (at least for checkout from git, make dist
> would be a different topic).
>
> holger

Reply via email to