Patch Set 4: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/118/4/tests/codec/codec_test.c File tests/codec/codec_test.c: Line 35: int rc = osmo_amr_rtp_dec(t, len, &cmr, &cmi, &ft, &bfi, &sti); What I really like are roud-trip tests. Decode, encode and check if they are the same. Could you add one here? -- To view, visit https://gerrit.osmocom.org/118 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia217679a07d3fbc970f435e20f6eac33d34bd597 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
