I recall that I've seen both variants in source code - "system before our" and "our headers before system". I'm more inclined towards latter but I'm open for other opinions.
On 07/13/2016 04:21 PM, Neels Hofmeyr wrote: > Hi Max, > > in e.g. e6052c4cc756f7d3a5023a0ba57fe8d80783967c you have added #include > <stdbool.h> in various files. > > I'd like to nitpick about the place where you put it: > > index 3cba5d1..3d7c244 100644 > --- a/openbsc/include/openbsc/gsm_subscriber.h > +++ b/openbsc/include/openbsc/gsm_subscriber.h > @@ -5,6 +5,8 @@ > #include <osmocom/core/linuxlist.h> > #include <osmocom/gsm/protocol/gsm_23_003.h> > > +#include <stdbool.h> > + > > (there are also some more instances) > > I'd prefer if we keep system headers grouped on top. > Thanks :) > > ~Neels > -- Max Suraev <[email protected]> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
