Hi. I think I can answer some of the questions. See comments below.
On 08/04/2016 01:50 PM, Vadim Yanitskiy wrote: > > > 1) Which approach is better to use? To store everything in a single file > or to use auto generation (utils/conv_gen.py)? I think extending utils/conv_gen.py is the way to go because it will allow us to have concise description of the convolutional codes in one place and as close to the description in standards as possible. > 2) What about the copyright? I have not seen any license/author info at > the top pf these files. Who is the author? Could you specify which files exactly are you referring to? Also you can use 'git blame' to clarify authorship. > > Also, there is the 'gsm0503_coding.c' file, which uses the following > external dependences: > > * The DL1C logging category, which isn't defined in libosmocore; I don't think library functions should do any sort of logging by itself (unless it's a logging functions of course :) Instead they should return clearly distinguishable values and let caller do the logging as they see fit. -- Max Suraev <[email protected]> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
