Hi Max, you recently tend to have very general commit log summaries. The summary should best contain a hint at the general area the patch is about, so a reader can quickly know whether a patch could be related to a given other topic. I've asked so on gerrit a few times, and now also found a couple of commits merged IMHO with ETOOGENERAL, so I thought I'd drop a note:
osmo-bts: 2017-01-06 17:30 Max o Log socket path on error 2017-01-02 18:17 Max o Move code to libosmocore 2016-11-11 17:44 Max o Remove duplicated code osmo-pcu: 2017-01-06 17:20 Max o Log socket path on connection 2017-01-05 18:26 Max o Improve logging Would be nice to add an indicator to the summary in the future. A small word or phrase in the beginning is enough, like 'rsl: frobnicate', or include a function name or -prefix for code dup / moved code. Thanks! ~N -- - Neels Hofmeyr <[email protected]> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
signature.asc
Description: Digital signature
