Hi, I'm working on the debian packaging of openca with Brian May.
I'm working with the latest snapshot 0.9.20031124, and for now I only tested the
ca submodule.
I found some problems and some bugs, I attach a patch:
src/common/etc/openca_start.template.in and src/common/lib/functions/initServer:
some problems in the perl syntax with the perl version present in debian SID (perl
v5.8.2):
- use strict qw(@ISA);; seems unaceptable
- some our global simbols declared in a subroutine scope.
src/web-interfaces/*/Makefile:
when creating symlinks, it could be wise to use relative paths, since it is more
common to
create danglink symlinks (moreover on deb package it creates some problems).
src/web-interfaces/ca/cmds/Makefile:
some commands seem missings: lists approveCSRnotSigned approveCSR.
They should be present even in the ca module, else the creation procedure of the
first
ca||ra admin certificates is broken.
I also found some problems in the initialization of the ca module:
when I try to create the ca admin certificate the "issue certificate" command
does not work. I follow the procedure:
- Make request
- Edit request
- Approve without signing
- Issue, after this point no certificate is issued and the certificate remains
in the approved status. Maybe the problem is in my package.
Thanks
Index: src/common/etc/openca_start.template.in
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/common/etc/openca_start.template.in,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/common/etc/openca_start.template.in 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/common/etc/openca_start.template.in 8 Dec 2003 13:20:54 -0000 1.2
@@ -9,7 +9,8 @@
package OpenCA::Server;
-use strict qw(@ISA);;
+use strict;
+use vars qw(@ISA);
no warnings;
use OpenCA::Configuration;
Index: src/common/lib/functions/initServer
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/common/lib/functions/initServer,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/common/lib/functions/initServer 8 Dec 2003 13:08:32 -0000 1.1.1.1
+++ src/common/lib/functions/initServer 8 Dec 2003 13:20:54 -0000 1.2
@@ -5,9 +5,13 @@
## Flush the output
$|=1;
-use strict qw (@ISA);;
+use strict;
+use vars qw(@ISA);
no warnings;
+
+our ($LANGUAGE, $performance_test, @performance);
+
## start performance accounting
resetPerformancePoints ();
@@ -384,7 +388,7 @@
sub setLanguage
{
- our $LANGUAGE = $_[0];
+ $LANGUAGE = $_[0];
setlocale(LC_MESSAGES, $LANGUAGE);
bindtextdomain("openca", $AUTOCONF{"lib_prefix"}."/locale");
textdomain("openca");
@@ -400,11 +404,11 @@
sub resetPerformancePoints
{
- our $performance_test = 0;
+ $performance_test = 0;
## activate the commented line if you want to use performance counters
## use Time::HiRes qw (tv_interval gettimeofday);
return 1 if (not $performance_test);
- our @performance = ();
+ @performance = ();
setPerformancePoint ("start time");
}
Index: src/web-interfaces/ca/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ca/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/web-interfaces/ca/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ca/Makefile 8 Dec 2003 16:20:16 -0000 1.2
@@ -61,7 +61,7 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@
$(DEST_CA_CGI_CONFDIR)/${ca_prefix}.conf.template; \
- $(LN_S) $(DEST_CA_CGI_CONFDIR)/${ca_prefix}.conf
$(DEST_CA_CGI_CONFDIR)/common.conf; \
+ $(LN_S) ${ca_prefix}.conf $(DEST_CA_CGI_CONFDIR)/common.conf; \
fi
$(COOKIE_DIR)::
Index: src/web-interfaces/ca/cmds/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ca/cmds/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- src/web-interfaces/ca/cmds/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ca/cmds/Makefile 18 Dec 2003 09:19:47 -0000
@@ -89,7 +89,10 @@
viewCSR \
viewCert \
viewSignature \
- warnExpiring
+ warnExpiring \
+ lists \
+ approveCSRnotSigned \
+ approveCSR
CMDS = $(AC_CMDS) $(STATIC_CMDS)
Index: src/web-interfaces/ldap/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ldap/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/web-interfaces/ldap/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ldap/Makefile 8 Dec 2003 16:20:18 -0000 1.2
@@ -61,7 +61,7 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@
$(DEST_LDAP_CGI_CONFDIR)/${ldap_prefix}.conf.template; \
- $(LN_S) $(DEST_LDAP_CGI_CONFDIR)/${ldap_prefix}.conf
$(DEST_LDAP_CGI_CONFDIR)/common.conf; \
+ $(LN_S) ${ldap_prefix}.conf $(DEST_LDAP_CGI_CONFDIR)/common.conf; \
fi
$(COOKIE_DIR)::
Index: src/web-interfaces/node/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/node/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.4
diff -u -r1.1.1.1 -r1.4
--- src/web-interfaces/node/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/node/Makefile 18 Dec 2003 08:23:24 -0000 1.4
@@ -61,7 +61,6 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@
$(DEST_NODE_CGI_CONFDIR)/${node_prefix}.conf.template; \
- $(LN_S) $(DEST_NODE_CGI_CONFDIR)/${node_prefix}.conf
$(DEST_NODE_CGI_CONFDIR)/common.conf; \
fi
$(COOKIE_DIR)::
Index: src/web-interfaces/pub/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/pub/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/web-interfaces/pub/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/pub/Makefile 8 Dec 2003 16:20:22 -0000 1.2
@@ -62,7 +62,7 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@
$(DEST_PUB_CGI_CONFDIR)/${pub_prefix}.conf.template; \
- $(LN_S) $(DEST_PUB_CGI_CONFDIR)/${pub_prefix}.conf
$(DEST_PUB_CGI_CONFDIR)/common.conf; \
+ $(LN_S) ${pub_prefix}.conf $(DEST_PUB_CGI_CONFDIR)/common.conf; \
fi
$(COOKIE_DIR)::
Index: src/web-interfaces/ra/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/ra/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/web-interfaces/ra/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/ra/Makefile 8 Dec 2003 16:20:24 -0000 1.2
@@ -61,7 +61,7 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@
$(DEST_RA_CGI_CONFDIR)/${ra_prefix}.conf.template; \
- $(LN_S) $(DEST_RA_CGI_CONFDIR)/${ra_prefix}.conf
$(DEST_RA_CGI_CONFDIR)/common.conf; \
+ $(LN_S) ${ra_prefix}.conf $(DEST_RA_CGI_CONFDIR)/common.conf; \
fi
$(COOKIE_DIR)::
Index: src/web-interfaces/scep/Makefile
===================================================================
RCS file: /var/cvs/openca-0.9.20031124/src/web-interfaces/scep/Makefile,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- src/web-interfaces/scep/Makefile 8 Dec 2003 13:08:31 -0000 1.1.1.1
+++ src/web-interfaces/scep/Makefile 8 Dec 2003 16:20:25 -0000 1.2
@@ -70,7 +70,7 @@
fi; \
set -x; \
$(INSTALL) -o ${openca_user} -g ${httpd_group} -m 640 $@
$(DEST_SCEP_CGI_CONFDIR)/${scep_prefix}.conf.template; \
- $(LN_S) $(DEST_SCEP_CGI_CONFDIR)/${scep_prefix}.conf
$(DEST_SCEP_CGI_CONFDIR)/common.conf; \
+ $(LN_S) ${scep_prefix}.conf $(DEST_SCEP_CGI_CONFDIR)/common.conf; \
fi
install clean distclean::
