Hello!
I have attached two txt files, where it is explained which new missing
gettext() calls and typos I found. I putted it as an attachment because it
was to much to be in a messgae ;-)
You have to consider that these are just the flaws I found so far while
testing the basic funcionalities...so, I would suggest to the authors of
the code to go through my descriptions and also to spend some time
to find out non-documented missing gettext() calls. With some inventivity,
it would be possible to automagically check all the code for addLogLine
and similiar calls and check if they use gettext or not.
In the other file, there are some spelling errors corrected.
And a question about gettext:
When I went with xgettext through all the code (after adding all cmds and
functions to the .list files) with the tool that comes with OpenCA, it
happened that in the openca.pot were missing some messages without any
special reason. When I looked for them in the source files (after finding
out that I don't have them in my openca.po) I found out that they were
messages with gettext() calls as well as without gettext() calls. So, it
is not that they were ignored because of not using gettext() calls. At the
same time, in my openca.po ended also some other messages from the same
files that xgettext went through, so it really makes no sense?!
And another thing about OpenCA:
When rebuilding the CA chain in the online node, it happens that it
says it was successful but you still get a whole page of erros when
building the chain ;-) What about it? I would say that the problem in my
case was that I didn't have the CA cert installed, but the rebuilding
function was proud of itself finishing succesfull ;-)
Good luck,
Janez
# common/lib/functions/export-import.lib:2089#:
common/lib/functions/export-import.lib:2097#:
common/lib/functions/export-import.lib:2101
#: common/lib/functions/export-import.lib:2089
msgid ""
"Cannot open directory __DIR__ to export the logs frm the imported objects."
mail-utils.lib:
sub sendPreparedMails {
...snip...
line cca. 256:
print addPreLogLine (i18nGettext ("Didn't find new mails. No mails send!")) if not
$found;
note: Correct would be "Didn't find new mails. No mails sent!" and not send ;-)
in library export-import.lib:
sub withLDAPautomatic {
my $ldap = getRequired ('updateLDAPautomatic');
if ( $ldap =~ /^(off|no)$/i ) {
print addLogSection (gettext ("Automatic LDAP-update is deactivated"));
print addLogLine ("");
print closeLogSection ();
return 0;
} else {
print addLogSection (gettext ("Automatic LDAP-update is activated"));
print addLogLine ("");
print closeLogSection ();
return 1;
}
}
note: added gettext()
sub importObjects {
our ($db, $cryptoShell);
my $keys = { @_ };
my @datatype = eximObjectsGetDatatype ( @_ );
my $DEBUG = 0;
print addLogSection (i18nGettext ("Importing __STATUS__ __OBJECT__ ...",
"__STATUS__", lc gettext($datatype [1]),
"__OBJECT__", gettext($datatype [0])) );
note: $datatype has also to go through gettext()
sub exportObjects {
our ($tools, $db);
my $keys = { @_ };
my @datatype = eximObjectsGetDatatype ( @_ );
print addLogSection ( i18nGettext ("Exporting __STATUS__ __OBJECT__ ...",
"__STATUS__", lc gettext($datatype [1]),
"__OBJECT__", gettext($datatype [0])) );
note: $datatype has also to go through gettext()
sub eximDownloadCAs {
...snip...
line cca. 1397:
print addLogLine (gettext("OK."));
note: added gettext()
sub eximDownloadMails {
our $tools;
my $exim_tmp_dir = $_[0];
foreach my $type (eximGetStates (DATATYPE => "MAIL", MODE => "DOWNLOAD"))
{
next if (not $type);
print addLogSection(i18nGettext ("Importing the Mails (__TYPE__) ... ",
"__TYPE__", uc(gettext($type))));
note: $type has to go through gettext()
sub eximDownloadMails {
...snip...
line cca. 1917:
print addPreLogLine (gettext ("No new mails found. No mails imported!")) if
(not $found);
note: added gettext()
sub eximDownloadBP {
...snip...
line cca. 1980:
print addLogLine (gettext("no data present"));
note: added gettext()
sub eximDownloadConfiguration {
line cca. 1777:
print addLogSection(gettext("Importing the OpenSSL-configuration of the roles ...
"));
line cca. 1780:
print addErrorLog(gettext("Cannot copy $openssl_dir to $h_openssl_dir!"));
line cca. 1785:
print addLogLine(gettext("Ok."));
line cca. 1793:
print addLogSection(gettext("Importing the configuration of the extensions of the
roles ... "));
line cca. 1796:
print addErrorLog(gettext("Cannot copy $ext_dir to $h_ext_dir!"));
line cca. 1801:
print addLogLine(gettext("Ok."));
note: added gettext()
in library misc-utils.lib:
sub success {
...snip...
line cca. 63:
return libSendReply (
"NAME" => gettext("Administration Success"),
"EXPLANATION" => $num,
"INFO_LIST" => $info_list
);
note: added gettext()
