configure.ac | 2 +- src/via_driver.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
New commits: commit 54de6f9253aa42ede211b7b3131cd9c818c5d173 Author: Kevin Brace <kevinbr...@gmx.com> Date: Wed Jun 22 14:50:12 2016 -0500 Version bumped to 0.4.902 (Version 0.5 RC3) The potential memory leak when X Server is being shutdown is remedied in this third release candidate. Signed-off-by: Kevin Brace <kevinbr...@gmx.com> diff --git a/configure.ac b/configure.ac index 8565123..9d4dc32 100644 --- a/configure.ac +++ b/configure.ac @@ -23,7 +23,7 @@ # Initialize Autoconf AC_PREREQ(2.57) AC_INIT([xf86-video-openchrome], - [0.4.901], + [0.4.902], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg&component=Driver/openchrome], [xf86-video-openchrome]) commit e28986aef13129cc22001f0a99c025548bb45659 Author: Kevin Brace <kevinbr...@gmx.com> Date: Wed Jun 22 14:46:09 2016 -0500 VIAFreeRec will be called from VIAFreeScreen Prior to commit 870d3c7, VIAFreeRec function was being called prior to the check to see if calling vgaHWFreeHWRec is necessary. Unfortunately, this check was referencing DDX's private storage area after it was freed by the call to VIAFreeRec function. This was leading to a segmentation fault during the X Server shutdown. In order to remedy this, the call to VIAFreeRec function was removed by commit 870d3c7. However, according to XFree86 DDX Design document (ddxDesign.pdf), VIAFreeRec function is expected to be called from VIAFreeScreen callback function. Not doing so very likely will lead to memory leak, hence, VIAFreeRec function will now be called from VIAFreeScreen callback function, but after vgaHWFreeHWRec is called. Signed-off-by: Kevin Brace <kevinbr...@gmx.com> diff --git a/src/via_driver.c b/src/via_driver.c index 653814d..37014c7 100644 --- a/src/via_driver.c +++ b/src/via_driver.c @@ -438,6 +438,8 @@ VIAFreeScreen(FREE_SCREEN_ARGS_DECL) if (xf86LoaderCheckSymbol("vgaHWFreeHWRec")) { vgaHWFreeHWRec(pScrn); } + + VIAFreeRec(pScrn); } static void _______________________________________________ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/openchrome-devel