drivers/gpu/drm/openchrome/via_analog.c | 2 ++ drivers/gpu/drm/openchrome/via_drv.c | 4 ++-- drivers/gpu/drm/openchrome/via_drv.h | 2 +- drivers/gpu/drm/openchrome/via_fp.c | 22 ++++++++++++---------- drivers/gpu/drm/openchrome/via_tmds.c | 10 +++++----- 5 files changed, 22 insertions(+), 18 deletions(-)
New commits: commit 5dbd0b289f90bb21de7455ca413bc956a63742c1 Author: Kevin Brace <kevinbr...@gmx.com> Date: Fri Nov 3 16:16:46 2017 -0700 drm/openchrome: Version bumped to 3.0.54 This version fixes the I2C display detection regression introduced by Version 3.0.52. Signed-off-by: Kevin Brace <kevinbr...@gmx.com> diff --git a/drivers/gpu/drm/openchrome/via_drv.h b/drivers/gpu/drm/openchrome/via_drv.h index fa300713917a..c426c885acd4 100644 --- a/drivers/gpu/drm/openchrome/via_drv.h +++ b/drivers/gpu/drm/openchrome/via_drv.h @@ -34,7 +34,7 @@ #define DRIVER_MAJOR 3 #define DRIVER_MINOR 0 -#define DRIVER_PATCHLEVEL 53 +#define DRIVER_PATCHLEVEL 54 #include <linux/module.h> commit 5ff6c8ec2b8df1808e302f833c7374c440ee9e4d Author: Kevin Brace <kevinbr...@gmx.com> Date: Fri Nov 3 16:10:48 2017 -0700 drm/openchrome: Fix debug messages Carriage return was missing. Signed-off-by: Kevin Brace <kevinbr...@gmx.com> diff --git a/drivers/gpu/drm/openchrome/via_drv.c b/drivers/gpu/drm/openchrome/via_drv.c index b61d908ac99c..c44c396228d2 100644 --- a/drivers/gpu/drm/openchrome/via_drv.c +++ b/drivers/gpu/drm/openchrome/via_drv.c @@ -541,7 +541,7 @@ static int via_pm_ops_suspend(struct device *dev) struct drm_device *drm_dev = pci_get_drvdata(pdev); struct via_device *dev_priv = drm_dev->dev_private; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); console_lock(); drm_fb_helper_set_suspend(&dev_priv->via_fbdev->helper, true); @@ -570,7 +570,7 @@ static int via_pm_ops_resume(struct device *dev) void __iomem *regs = ioport_map(0x3c0, 100); u8 val; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); console_lock(); diff --git a/drivers/gpu/drm/openchrome/via_fp.c b/drivers/gpu/drm/openchrome/via_fp.c index bed6f5767b11..3f4c11ba1315 100644 --- a/drivers/gpu/drm/openchrome/via_fp.c +++ b/drivers/gpu/drm/openchrome/via_fp.c @@ -686,7 +686,7 @@ static void via_fp_dpms(struct drm_encoder *encoder, int mode) /* PCI Device ID */ u16 chipset = dev->pdev->device; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); switch (mode) { case DRM_MODE_DPMS_ON: @@ -703,7 +703,7 @@ static void via_fp_dpms(struct drm_encoder *encoder, int mode) break; } - DRM_DEBUG_KMS("Exiting %s.", __func__); + DRM_DEBUG_KMS("Exiting %s.\n", __func__); } static bool @@ -781,7 +781,7 @@ static void via_fp_prepare(struct drm_encoder *encoder) /* PCI Device ID */ u16 chipset = dev->pdev->device; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); via_fp_power(dev_priv, chipset, enc->di_port, false); via_fp_io_pad_setting(dev_priv, enc->di_port, false); @@ -799,7 +799,7 @@ static void via_fp_commit(struct drm_encoder *encoder) /* PCI Device ID */ u16 chipset = dev->pdev->device; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); via_fp_power(dev_priv, chipset, enc->di_port, true); via_fp_io_pad_setting(dev_priv, enc->di_port, true); @@ -897,7 +897,7 @@ static void via_fp_disable(struct drm_encoder *encoder) /* PCI Device ID */ u16 chipset = dev->pdev->device; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); via_fp_power(dev_priv, chipset, enc->di_port, false); via_fp_io_pad_setting(dev_priv, enc->di_port, false); diff --git a/drivers/gpu/drm/openchrome/via_tmds.c b/drivers/gpu/drm/openchrome/via_tmds.c index bd1aafaf8c38..dda5c2893701 100644 --- a/drivers/gpu/drm/openchrome/via_tmds.c +++ b/drivers/gpu/drm/openchrome/via_tmds.c @@ -236,7 +236,7 @@ static void via_tmds_prepare(struct drm_encoder *encoder) struct via_encoder, base); struct via_device *dev_priv = encoder->dev->dev_private; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); via_tmds_power(dev_priv, false); via_tmds_io_pad_setting(dev_priv, enc->di_port, false); @@ -250,7 +250,7 @@ static void via_tmds_commit(struct drm_encoder *encoder) struct via_encoder, base); struct via_device *dev_priv = encoder->dev->dev_private; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); via_tmds_power(dev_priv, true); via_tmds_io_pad_setting(dev_priv, enc->di_port, true); @@ -270,7 +270,7 @@ via_tmds_mode_set(struct drm_encoder *encoder, struct via_crtc *iga = container_of(encoder->crtc, struct via_crtc, base); - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); via_tmds_init_reg(dev_priv); via_tmds_sync_polarity(dev_priv, adjusted_mode->flags); @@ -285,7 +285,7 @@ static void via_tmds_disable(struct drm_encoder *encoder) struct via_encoder, base); struct via_device *dev_priv = encoder->dev->dev_private; - DRM_DEBUG_KMS("Entered %s.", __func__); + DRM_DEBUG_KMS("Entered %s.\n", __func__); via_tmds_power(dev_priv, false); via_tmds_io_pad_setting(dev_priv, enc->di_port, false); commit 924d6b5b13d9ea65824ae538d0dcbbd228cd4ab9 Author: Kevin Brace <kevinbr...@gmx.com> Date: Fri Nov 3 16:07:29 2017 -0700 drm/openchrome: Remove unused variables from via_fp_probe Signed-off-by: Kevin Brace <kevinbr...@gmx.com> diff --git a/drivers/gpu/drm/openchrome/via_fp.c b/drivers/gpu/drm/openchrome/via_fp.c index 3715567965d4..bed6f5767b11 100644 --- a/drivers/gpu/drm/openchrome/via_fp.c +++ b/drivers/gpu/drm/openchrome/via_fp.c @@ -1446,11 +1446,9 @@ void via_fp_probe(struct drm_device *dev) void via_lvds_init(struct drm_device *dev) { struct via_device *dev_priv = dev->dev_private; - bool dual_channel = false, is_msb = false; + bool dual_channel = false; struct via_connector *con; struct via_encoder *enc; - struct edid *edid; - u8 reg_value; if ((!(dev_priv->int_fp1_presence)) && (!(dev_priv->int_fp2_presence))) { commit bd7a2e3fecfbf31ebc4b44d61c6be851dc432e8a Author: Kevin Brace <kevinbr...@gmx.com> Date: Fri Nov 3 16:03:55 2017 -0700 drm/openchrome: Fix I2C display detection regression This affected analog, FP, and DVI (integrated TMDS transmitter). Signed-off-by: Kevin Brace <kevinbr...@gmx.com> diff --git a/drivers/gpu/drm/openchrome/via_analog.c b/drivers/gpu/drm/openchrome/via_analog.c index f4393701bb72..4eac3dea5e1f 100644 --- a/drivers/gpu/drm/openchrome/via_analog.c +++ b/drivers/gpu/drm/openchrome/via_analog.c @@ -223,6 +223,8 @@ via_analog_detect(struct drm_connector *connector, bool force) DRM_DEBUG_KMS("Entered %s.\n", __func__); + drm_mode_connector_update_edid_property(connector, edid); + if (con->i2c_bus & VIA_I2C_BUS1) { i2c_bus = via_find_ddc_bus(0x26); } else { diff --git a/drivers/gpu/drm/openchrome/via_fp.c b/drivers/gpu/drm/openchrome/via_fp.c index ab4bb8bd13b0..3715567965d4 100644 --- a/drivers/gpu/drm/openchrome/via_fp.c +++ b/drivers/gpu/drm/openchrome/via_fp.c @@ -922,13 +922,16 @@ const struct drm_encoder_funcs via_lvds_enc_funcs = { static enum drm_connector_status via_lcd_detect(struct drm_connector *connector, bool force) { - struct via_connector *con = container_of(connector, struct via_connector, base); + struct via_connector *con = container_of(connector, + struct via_connector, base); enum drm_connector_status ret = connector_status_disconnected; struct i2c_adapter *i2c_bus; struct edid *edid = NULL; DRM_DEBUG_KMS("Entered %s.\n", __func__); + drm_mode_connector_update_edid_property(connector, edid); + if (con->i2c_bus & VIA_I2C_BUS2) { i2c_bus = via_find_ddc_bus(0x31); } else if (con->i2c_bus & VIA_I2C_BUS3) { @@ -940,7 +943,8 @@ via_lcd_detect(struct drm_connector *connector, bool force) if (i2c_bus) { edid = drm_get_edid(&con->base, i2c_bus); if (edid) { - drm_mode_connector_update_edid_property(&con->base, edid); + drm_mode_connector_update_edid_property(connector, + edid); kfree(edid); ret = connector_status_connected; } diff --git a/drivers/gpu/drm/openchrome/via_tmds.c b/drivers/gpu/drm/openchrome/via_tmds.c index d9e45d254206..bd1aafaf8c38 100644 --- a/drivers/gpu/drm/openchrome/via_tmds.c +++ b/drivers/gpu/drm/openchrome/via_tmds.c @@ -324,7 +324,7 @@ via_tmds_detect(struct drm_connector *connector, bool force) } if (i2c_bus) { - edid = drm_get_edid(connector, i2c_bus); + edid = drm_get_edid(&con->base, i2c_bus); if (edid) { if ((connector->connector_type == DRM_MODE_CONNECTOR_DVIA) ^ (edid->input & DRM_EDID_INPUT_DIGITAL)) { _______________________________________________ Openchrome-devel mailing list Openchrome-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/openchrome-devel